blockifier_test_utils: add option to deploy from zero in test accounts#14258
Conversation
PR SummaryLow Risk Overview Call sites across blockifier, apollo integration tests, and OS flow tests append Fixture churn from the contract change: proof-flow facts, genesis global root, STRK fee token address, fuzz contract addresses, bouncer migration gas snapshots, and a few OS metric expectations. Docs/ignore now reference Reviewed by Cursor Bugbot for commit bdfa06c. Bugbot is set up for automated code reviews on this repo. Configure here. |
f886597 to
80911a6
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 15 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).
.gitignore line 21 at r1 (raw file):
*.DS_Store tmp_venv/* blockifier_test_venv/*
What is it?
Code quote:
blockifier_test_venv57672ac to
bd20dd7
Compare
80911a6 to
0f58759
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 3 comments.
Reviewable status: 15 of 16 files reviewed, 3 unresolved discussions (waiting on yoavGrs and Yoni-Starkware).
.gitignore line 21 at r1 (raw file):
Previously, yoavGrs wrote…
What is it?
see new diff
crates/apollo_integration_tests/src/state_reader.rs line 385 at r1 (raw file):
/// starknet_transaction_prover/stwo_proving --release generate_proof_fixtures -- --ignored`. pub const EXPECTED_PROOF_FLOW_GENESIS_GLOBAL_ROOT: Expect = expect!["0x3016bfaeed7f65d42466c0c216ad9d9da23d7152ec746be3db8b627c0b7446b"];
proof regeneration is required every time the account contract changes...?
Code quote:
expect!["0x3016bfaeed7f65d42466c0c216ad9d9da23d7152ec746be3db8b627c0b7446b"];.gitignore line 21 at r1 (raw file):
*.DS_Store tmp_venv/* blockifier_test_venv/*
had to recompile a cairo0 contract in the blockifier test utils venv, this is useful to ignore
Code quote:
blockifier_test_venv/*
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status: 15 of 16 files reviewed, 2 unresolved discussions (waiting on yoavGrs and Yoni-Starkware).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on yoavGrs and Yoni-Starkware).
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
crates/apollo_integration_tests/src/state_reader.rs line 385 at r1 (raw file):
Previously, dorimedini-starkware wrote…
proof regeneration is required every time the account contract changes...?
The genesis global root depends on the account that initializes the flow.
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_os_flow_tests/src/virtual_os_test.rs#L366-L375
0f58759 to
b11ed41
Compare
|
Artifacts upload workflows: |
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
b11ed41 to
bdfa06c
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 19 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

No description provided.