Skip to content

blockifier_test_utils: add option to deploy from zero in test accounts#14258

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts
Jun 2, 2026
Merged

blockifier_test_utils: add option to deploy from zero in test accounts#14258
dorimedini-starkware merged 1 commit into
mainfrom
05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented May 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only contract ABI and fixture updates; production execution paths unchanged aside from aligned test calldata.

Overview
Test account contracts in blockifier_test_utils now take an explicit deploy_from_zero argument on deploy_contract (Cairo0 and Cairo1), forwarding it to the deploy syscall instead of hard-coding FALSE / false.

Call sites across blockifier, apollo integration tests, and OS flow tests append false to deploy calldata so behavior stays the same while tests can opt into deploy-from-zero later. The Cairo0 dummy account compiled JSON and stack-trace golden files were refreshed for the new ABI layout.

Fixture churn from the contract change: proof-flow facts, genesis global root, STRK fee token address, fuzz contract addresses, bouncer migration gas snapshots, and a few OS metric expectations. Docs/ignore now reference blockifier_test_venv instead of reqs_venv.

Reviewed by Cursor Bugbot for commit bdfa06c. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 29, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts branch from f886597 to 80911a6 Compare June 1, 2026 08:37

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 15 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).


.gitignore line 21 at r1 (raw file):

*.DS_Store
tmp_venv/*
blockifier_test_venv/*

What is it?

Code quote:

blockifier_test_venv

@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes branch from 57672ac to bd20dd7 Compare June 1, 2026 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts branch from 80911a6 to 0f58759 Compare June 1, 2026 09:49

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 3 comments.
Reviewable status: 15 of 16 files reviewed, 3 unresolved discussions (waiting on yoavGrs and Yoni-Starkware).


.gitignore line 21 at r1 (raw file):

Previously, yoavGrs wrote…

What is it?

see new diff


crates/apollo_integration_tests/src/state_reader.rs line 385 at r1 (raw file):

/// starknet_transaction_prover/stwo_proving --release generate_proof_fixtures -- --ignored`.
pub const EXPECTED_PROOF_FLOW_GENESIS_GLOBAL_ROOT: Expect =
    expect!["0x3016bfaeed7f65d42466c0c216ad9d9da23d7152ec746be3db8b627c0b7446b"];

proof regeneration is required every time the account contract changes...?

Code quote:

expect!["0x3016bfaeed7f65d42466c0c216ad9d9da23d7152ec746be3db8b627c0b7446b"];

.gitignore line 21 at r1 (raw file):

*.DS_Store
tmp_venv/*
blockifier_test_venv/*

had to recompile a cairo0 contract in the blockifier test utils venv, this is useful to ignore

Code quote:

blockifier_test_venv/*

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 15 of 16 files reviewed, 2 unresolved discussions (waiting on yoavGrs and Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on yoavGrs and Yoni-Starkware).

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).


crates/apollo_integration_tests/src/state_reader.rs line 385 at r1 (raw file):

Previously, dorimedini-starkware wrote…

proof regeneration is required every time the account contract changes...?

The genesis global root depends on the account that initializes the flow.
https://github.com/starkware-libs/sequencer/blob/main/crates/starknet_os_flow_tests/src/virtual_os_test.rs#L366-L375

@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts branch from 0f58759 to b11ed41 Compare June 1, 2026 10:24
@graphite-app graphite-app Bot changed the base branch from 05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes to main June 1, 2026 10:48
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Artifacts upload workflows:

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts branch from b11ed41 to bdfa06c Compare June 2, 2026 08:36

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 19 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 6be6e6c Jun 2, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants