Skip to content

starknet_os: os resources test - declare tx#14147

Closed
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_declare_tx
Closed

starknet_os: os resources test - declare tx#14147
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_declare_tx

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and versioned-constants snapshot updates for fee/resource accounting; no production execution-path logic changes beyond refreshed constant numbers.

Overview
Extends test_execute_txs_inner_resources so declare transactions are measured alongside invoke: the test now runs two txs, subtracts blockifier business-logic resources from full OS trace resources per tx, and writes the declare remainder into versioned constants as a constant execute_txs_inner.Declare entry (invoke overhead is still updated the same way).

blockifier_versioned_constants_0_14_4.json is refreshed with the new declare OS scaffolding cost (3938 steps, 92 range-check builtins, up from the previous placeholder values).

The declare path uses a stable, unmodified class (DATA_GAS_ACCOUNT_CONTRACT_*) so measurements do not drift from recompilation. DeployableForResourceMeasurement gains __validate_declare__ and matching Sierra/CASM artifacts so account validation for declare is realistic for resource tests. Minor formatting-only edits appear in os_resources_test_contract.cairo.

Reviewed by Cursor Bugbot for commit 22acdc7. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from fbfd93e to f4340dd Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch 2 times, most recently from c632d3d to e678a92 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from f4340dd to 25d975a Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from e678a92 to c2f6aca Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 25d975a to 96d404c Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from c2f6aca to 350efcf Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 96d404c to 1e60c06 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch 2 times, most recently from d1652f9 to b73625a Compare June 1, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants