Skip to content

starknet_os_flow_tests: helper function to declare explicit classes#14257

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes
Jun 1, 2026
Merged

starknet_os_flow_tests: helper function to declare explicit classes#14257
dorimedini-starkware merged 1 commit into
mainfrom
05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

This was referenced May 29, 2026
@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 29, 2026 14:06
@cursor

cursor Bot commented May 29, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor in flow tests; no production OS or execution logic changes.

Overview
Adds TestBuilder::add_explicit_cairo1_declare_tx, which builds a Cairo 1 declare from Sierra + CASM (class/compiled hashes, ClassInfo, DeclareTransaction::create) and forwards to add_cairo1_declare_tx.

test_v1_bound_accounts_cairo1 and test_data_gas_accounts now call that helper instead of repeating the same declare boilerplate; imports in test_manager.rs are adjusted to match.

Reviewed by Cursor Bugbot for commit 47fc472. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 6593ca5 to 99778d3 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes branch from d3076e2 to 57672ac Compare June 1, 2026 08:37

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account to graphite-base/14257 June 1, 2026 09:47
@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes branch from 57672ac to bd20dd7 Compare June 1, 2026 09:49
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14257 to 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account June 1, 2026 09:49
@graphite-app graphite-app Bot changed the base branch from 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account to main June 1, 2026 10:11
@dorimedini-starkware dorimedini-starkware force-pushed the 05-29-starknet_os_flow_tests_helper_function_to_declare_explicit_classes branch from bd20dd7 to 47fc472 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit 119cff9 Jun 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants