Skip to content

starknet_os: resources test - deploy account#14416

Open
dorimedini-starkware wants to merge 1 commit into
06-08-starknet_os_resources_test_-_declarefrom
06-08-starknet_os_resources_test_-_deploy_account
Open

starknet_os: resources test - deploy account#14416
dorimedini-starkware wants to merge 1 commit into
06-08-starknet_os_resources_test_-_declarefrom
06-08-starknet_os_resources_test_-_deploy_account

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Updates versioned DeployAccount OS overhead used for resource/fee accounting; values are test-measured but still affect deploy-account cost modeling if wrong.

Overview
Extends the OS execute_txs_inner resource regression test to cover deploy account transactions (previously only invoke and declare).

test_execute_txs_inner_resources now runs two funded deploy-account txs with minimal vs extended constructor calldata, derives constant and scaled calldata-factor overhead the same way as invoke, and writes TransactionType::DeployAccount into the measured versioned constants. The test block grows from 3 to 5 transactions, with deploy txs prepared and funded in an earlier block so funding does not pollute the measurement block.

blockifier_versioned_constants_0_14_4.json updates DeployAccount constant OS scaffolding: n_steps 4583 → 4989 and adjusted range-check / Pedersen / Poseidon builtin counts. The 0.14.3 → 0.14.4 constants diff regression file records those DeployAccount constant changes.

Reviewed by Cursor Bugbot for commit 8586934. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from 124e469 to de0acc0 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from f8574a1 to b75dab6 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from de0acc0 to fa76fed Compare June 8, 2026 11:59
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch 2 times, most recently from f253770 to c156411 Compare June 9, 2026 11:37
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from fa76fed to 78fae78 Compare June 9, 2026 11:37
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from 78fae78 to e99d6e3 Compare June 9, 2026 12:01
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from c156411 to 8586934 Compare June 9, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants