Skip to content

starknet_os: os resources test - l1 handler tx constant factor#14149

Closed
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor
Closed

starknet_os: os resources test - l1 handler tx constant factor#14149
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches versioned constants used for OS transaction resource accounting; incorrect values could mis-estimate fees but changes are test-driven regression updates.

Overview
Extends test_execute_txs_inner_resources so L1 handler transactions are measured alongside invoke, declare, and deploy-account. The test runs a minimal L1 handler on the stable contract, subtracts blockifier business-logic resources from full OS trace resources, and writes the measured constant overhead into execute_txs_inner for TransactionType::L1Handler (still unscaled calldata factor; linear factor left as TODO).

Updates blockifier_versioned_constants_0_14_4.json for L1Handler constant OS scaffolding: n_steps 1315 → 1342, pedersen_builtin 11 → 12, matching the new regression measurement.

Reviewed by Cursor Bugbot for commit e0f48d1. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from b5eae2f to 4a8df3d Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 43d9d8e to 3e2e6c5 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 4a8df3d to dc5adbd Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 3e2e6c5 to cb37a07 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from dc5adbd to 67b8cfa Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from cb37a07 to 22ef08b Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 22ef08b to 92ed53b Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 67b8cfa to 8ac7b12 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 8ac7b12 to e916599 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch 2 times, most recently from cf82050 to abc03de Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 49eb712 to ff31b35 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from abc03de to e0f48d1 Compare June 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants