starknet_os: define sha256 batch resources constants

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_os: os resources test - add send_message_to_l1 #14143 : 2 dependent PRs (#14144 , #14153 )
• starknet_os: os resources test - add replace_class #14142
• starknet_os: os resources test - support virtual builtins, add sha256 #14141
• starknet_os: define sha256 batch resources constants #14140 👈 (View in Graphite)
• starknet_os: os resources test - add keccak #14139
• starknet_os: os resources test - add 3 more syscalls #14138
• starknet_os: os resources test - remove all fee transfer syscalls #14137
• starknet_os: os resources test - add emit event #14136
• starknet_os: os resources test - add meta tx #14135
• starknet_os: os resources test - measure linear factor, add deploy #14134
• starknet_os: os resources test - library call #14129
• starknet_os: initial test, measure call contract resources #14128
• blockifier_test_utils: add option to deploy from zero in test accounts #14258
• starknet_os_flow_tests: helper function to declare explicit classes #14257
• starknet_os: os resources test - create fixed deployable account #14173
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Test-only resource constants and a VM integration test; no production OS or syscall logic changes in this diff.

Overview
Adds documented Cairo execution resource costs for the OS program’s SHA-256 batch phase, split into per-round linear and constant ExecutionResources (SHA256_BATCH_RESOURCES_LINEAR / SHA256_BATCH_RESOURCES_CONSTANT in test_utils).

A new integration test runs finalize_sha256 from OS_PROGRAM_BYTES via the existing Cairo runner helpers, samples two block counts that differ by one batch round (7 blocks per round), and regression-checks that measured linear and constant factors match those constants.

^{Reviewed by Cursor Bugbot for commit 335dd5f. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).

---

crates/starknet_os/src/resource_utils_test.rs line 44 at r1 (raw file):

        let len = input.len();
        let message: &[u32; 16] = input[len - 24..len - 8].try_into().unwrap();
        let state: &[u32; 8] = input[len - 8..].try_into().unwrap();

Try to avoid the indexing

Suggestion:

        let message: [u32; 16] = rng.gen();
        let state: [u32; 8] = rng.gen();
        input.extend_from_slice(&message.into());
        input.extend_from_slice(&state.into());

---

crates/starknet_os/src/resource_utils_test.rs line 100 at r1 (raw file):

#[test]
fn test_finalize_sha256() {
    // Sha256 batching resources has a linear factor and a constant factor. Sample the execution at

Suggestion:

has a linear factor by the number of rounds 

---

crates/starknet_os/src/resource_utils_test.rs line 102 at r1 (raw file):

    // Sha256 batching resources has a linear factor and a constant factor. Sample the execution at
    // two points to compute both factors.
    let block_to_round = 7_usize;

From where this number come from?

Suggestion:

let blocks_in_round = 7_usize;

---

crates/starknet_os/src/test_utils.rs line 22 at r1 (raw file):

// Resources consumed by the SHA-256 batch phase, separated into linear and constant factors.
pub static SHA256_BATCH_RESOURCES_LINEAR: LazyLock<ExecutionResources> =

Why don't we need it in the VC?

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).

---

crates/starknet_os/src/test_utils.rs line 22 at r1 (raw file):

Previously, yoavGrs wrote…

Why don't we need it in the VC?

OK, these are the resources of a round.
Reflect it in the constant name / the comment.

[dorimedini-starkware]

@dorimedini-starkware made 4 comments.
Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on yoavGrs and Yoni-Starkware).

---

crates/starknet_os/src/resource_utils_test.rs line 44 at r1 (raw file):

Previously, yoavGrs wrote…

Try to avoid the indexing

Done.

---

crates/starknet_os/src/resource_utils_test.rs line 102 at r1 (raw file):

Previously, yoavGrs wrote…

From where this number come from?

this is called BATCH_SIZE in the cairo common library implementing SHA

---

crates/starknet_os/src/test_utils.rs line 22 at r1 (raw file):

Previously, yoavGrs wrote…

OK, these are the resources of a round.
Reflect it in the constant name / the comment.

the resources of a batch, I think, is the terminology; hence BATCH_RESOURCES

---

crates/starknet_os/src/resource_utils_test.rs line 100 at r1 (raw file):

#[test]
fn test_finalize_sha256() {
    // Sha256 batching resources has a linear factor and a constant factor. Sample the execution at

Done.

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages, and resolved 4 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).