Skip to content

starknet_os: os resources test - l1 handler tx calldata factor#14152

Closed
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor
Closed

starknet_os: os resources test - l1 handler tx calldata factor#14152
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only change to OS resource regression measurement and expected versioned-constants snapshot; no production execution path changes.

Overview
Extends test_execute_txs_inner_resources so L1 handler OS overhead is measured with base vs. extra calldata, not a single aggregate.

Adds a second L1 handler tx (one extra calldata element), bumps N_TXS to 7, and splits trace overhead into l1_handler_base and l1_handler_extra. Versioned constants for TransactionType::L1Handler now set constant to the base overhead and calldata_factor to Unscaled(extra − base), removing the prior TODO. The test still snapshots the latest VC JSON via expect_file!.

Reviewed by Cursor Bugbot for commit 9c2eff6. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch from 5dbac28 to d5aaebf Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 77fc062 to b07e51e Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch 2 times, most recently from 7505307 to ebdeac0 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch from ebdeac0 to 82597b0 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 4ff38f8 to 8817938 Compare May 29, 2026 14:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82597b0. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch 2 times, most recently from a054ea9 to f0b2689 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_calldata_factor branch from f0b2689 to 9c2eff6 Compare June 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants