Skip to content

starknet_os: resources test - l1 handler#14417

Open
dorimedini-starkware wants to merge 1 commit into
06-08-starknet_os_resources_test_-_deploy_accountfrom
06-08-starknet_os_resources_test_-_l1_handler
Open

starknet_os: resources test - l1 handler#14417
dorimedini-starkware wants to merge 1 commit into
06-08-starknet_os_resources_test_-_deploy_accountfrom
06-08-starknet_os_resources_test_-_l1_handler

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

dorimedini-starkware commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes versioned OS resource constants used for L1 handler gas accounting; incorrect values would skew fees/limits even though the change is test-driven measurement.

Overview
Extends the OS execute_txs_inner resource regression test to cover L1 handler transactions (removing the prior TODO), using the same pattern as invoke/deploy: two minimal handler txs with different calldata lengths to derive constant OS overhead and an unscaled calldata linear factor.

The measured L1Handler constant n_steps in blockifier_versioned_constants_0_14_4.json is updated 1315 → 1329, with the 0.14.3→0.14.4 constants diff regression file adjusted accordingly. test_l1_handler expected total L2 gas snapshots are bumped by 1400 (KZG and non-KZG) to match the revised OS resource accounting.

Reviewed by Cursor Bugbot for commit e9193f4. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from f8574a1 to b75dab6 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_l1_handler branch 2 times, most recently from 5354acd to 2c8e97f Compare June 8, 2026 11:59
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch 2 times, most recently from f253770 to c156411 Compare June 9, 2026 11:37
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_l1_handler branch 2 times, most recently from 8f36f78 to c3b25f2 Compare June 9, 2026 12:01
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch 2 times, most recently from 8586934 to 65f48cb Compare June 9, 2026 12:25
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_l1_handler branch from c3b25f2 to 11deb64 Compare June 9, 2026 12:25

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 11deb64. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_l1_handler branch from 11deb64 to e9193f4 Compare June 9, 2026 13:06
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_deploy_account branch from 65f48cb to 0906746 Compare June 9, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants