Skip to content

starknet_os: os resources test - library call#14129

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-21-starknet_os_os_resources_test_-_library_call
Jun 2, 2026
Merged

starknet_os: os resources test - library call#14129
dorimedini-starkware merged 1 commit into
mainfrom
05-21-starknet_os_os_resources_test_-_library_call

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 8b1afb6 to a3596f2 Compare May 24, 2026 06:50
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from a5cf1a7 to c7c8260 Compare May 24, 2026 06:50
@github-actions

github-actions Bot commented May 24, 2026

Copy link
Copy Markdown

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes syscall gas costs, OS resource tables, and allowed virtual OS program hashes used for proving and execution accounting; incorrect values would break consensus or client proving compatibility.

Overview
Adds library_call to the OS resources measurement path so its Starknet OS overhead is regression-tested alongside other syscalls, and aligns fee / resource constants with the remeasured values.

The measurement contract’s __execute__ now invokes library_call_syscall after call_contract. LibraryCall is removed from the unmeasurable syscall list in os_resources_test, and 0.14.4 versioned constants set LibraryCall OS resources to 874 steps (down from 879). Cairo OS constants lower LIBRARY_CALL_GAS_COST (88660 vs 89160), and program_hash.json plus the third allowed virtual OS program hash are updated for the rebuilt OS / virtual OS binaries. Blockifier library_call syscall tests expect the corresponding gas deltas.

Reviewed by Cursor Bugbot for commit a2fa830. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14129 to 05-21-starknet_os_initial_test_measure_call_contract_resources May 29, 2026 14:05
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 7c93b0f to 74fde47 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch 2 times, most recently from 32d8f5d to d3d17db Compare June 1, 2026 10:24

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.2_0.14.3.txt Outdated

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.2_0.14.3.txt Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from d3d17db to c6a0aed Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_initial_test_measure_call_contract_resources to graphite-base/14129 June 2, 2026 11:05
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from c6a0aed to dba61e7 Compare June 2, 2026 12:02
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14129 to 05-21-starknet_os_initial_test_measure_call_contract_resources June 2, 2026 12:02

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion and dismissed @Yoni-Starkware from a discussion.
Reviewable status: 7 of 8 files reviewed, all discussions resolved (waiting on yoavGrs).

@graphite-app graphite-app Bot changed the base branch from 05-21-starknet_os_initial_test_measure_call_contract_resources to main June 2, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from dba61e7 to 28e70b3 Compare June 2, 2026 14:05
@graphite-app

graphite-app Bot commented Jun 2, 2026

Copy link
Copy Markdown

Merge activity

  • Jun 2, 2:05 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 28e70b3 to a2fa830 Compare June 2, 2026 14:18

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 9174010 Jun 2, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants