Skip to content

starknet_os: os resources test - add secp syscalls#14144

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1from
05-23-starknet_os_os_resources_test_-_add_secp_syscalls
Open

starknet_os: os resources test - add secp syscalls#14144
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1from
05-23-starknet_os_os_resources_test_-_add_secp_syscalls

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

Artifacts upload workflows:

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches versioned OS program hashes, allowed virtual OS hashes, and syscall gas/step tables used for fee accounting and proving compatibility.

Overview
Adds secp256k1/r1 syscalls to the OS resources regression path by exercising all ten SECP syscalls from OsResourcesTestContract, dropping them from UNMEASURABLE_SYSCALLS, and teaching test_os_resources_regression to ignore a second trace for Secp256k1New / Secp256r1New.

Refreshes protocol constants from those measurements: lower n_steps for each SECP syscall in blockifier_versioned_constants_0_14_4.json, matching SECP gas constants in constants.cairo, updated program_hash.json (OS + virtual OS), and the 0.14.3→0.14.4 VC diff regression file.

Test expectations are bumped for SECP integration tests (gas_consumed) and test_syscall_gas_cost_calculation (Secp256k1Mul gas).

Reviewed by Cursor Bugbot for commit 441a10e. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 39edd2e to b4dc505 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch 2 times, most recently from ac5afa2 to 82b5e4f Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from b4dc505 to 6d69bf0 Compare May 28, 2026 16:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82b5e4f. Configure here.

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.3_0.14.4.txt Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 6d69bf0 to a359fa6 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 82b5e4f to 41c9f3d Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from a359fa6 to dda5432 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 41c9f3d to 985e731 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from dda5432 to c91e910 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch 2 times, most recently from 485162f to e935403 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 18c656c to b7607b6 Compare June 8, 2026 10:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from e935403 to 2703304 Compare June 8, 2026 10:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 2703304 to 441a10e Compare June 9, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from b7607b6 to 1cc8b43 Compare June 9, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants