starknet_os: initial test, measure call contract resources#14128
Conversation
c3c76fd to
9b22fec
Compare
fc51ad3 to
6a4dbd9
Compare
9b22fec to
1e1aa17
Compare
6a4dbd9 to
a5cf1a7
Compare
a5cf1a7 to
c7c8260
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 4 of 19 files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 130 at r4 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Replace. The second one is the pending hash of v0.14.3.
I assume I should be appending now, for 0.14.4. right?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2fa8eff. Configure here.
2fa8eff to
7c93b0f
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 4 of 22 files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 131 at r6 (raw file):
"0x3e98c2d7703b03a7edb73ed7f075f97f1dcbaa8f717cdf6e1a57bf058265473", "0x6ecb73d21c7d98ddd4148f5bcd91cc2747c65364245fbf32a63b05cca1685c2", "0x59a0052ae80a978ca71126c9774a17c67c19f79b14bb9d1ea96fb77dc6032d8"
0.14.3 is on a separate branch so I should be appending here, correct? @Yoni-Starkware
Code quote:
"0x59a0052ae80a978ca71126c9774a17c67c19f79b14bb9d1ea96fb77dc6032d8"f886597 to
80911a6
Compare
7c93b0f to
74fde47
Compare
80911a6 to
b11ed41
Compare
74fde47 to
21fd6e4
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 22 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).
crates/central_systest_blobs/resources/blob_file_generation line 1 at r6 (raw file):
27
What is it?
Code quote:
27
crates/starknet_os_flow_tests/src/os_resources_test.rs line 197 at r6 (raw file):
test_output.perform_default_validations(); // Extract syscall resources consumed, per (measurable) syscall.
You're extracting all syscalls.
Suggestion:
per syscallcrates/starknet_os_flow_tests/src/os_resources_test.rs line 223 at r6 (raw file):
let inner_overhead = if selector.is_calling_syscall() { // TODO(Dori): Take opcodes (like blake) into account. inner_calls_iter.next().unwrap().resources.vm_resources
Assuming the inner call (if it exists) is a leaf in the call's tree.
Comment about it?
Code quote:
inner_calls_iter.next().unwrap().resources.vm_resourcesb11ed41 to
6be6e6c
Compare
21fd6e4 to
3a09774
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 3 comments and resolved 2 discussions.
Reviewable status: 21 of 22 files reviewed, 3 unresolved discussions (waiting on yoavGrs).
crates/central_systest_blobs/resources/blob_file_generation line 1 at r6 (raw file):
Previously, yoavGrs wrote…
What is it?
f2f
crates/starknet_os_flow_tests/src/os_resources_test.rs line 197 at r6 (raw file):
Previously, yoavGrs wrote…
You're extracting all syscalls.
Done.
crates/starknet_os_flow_tests/src/os_resources_test.rs line 223 at r6 (raw file):
Previously, yoavGrs wrote…
Assuming the inner call (if it exists) is a leaf in the call's tree.
Comment about it?
Done.
3a09774 to
d24049e
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 7 files and all commit messages, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).


No description provided.