Skip to content

starknet_os: initial test, measure call contract resources#14128

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-21-starknet_os_initial_test_measure_call_contract_resources
Jun 2, 2026
Merged

starknet_os: initial test, measure call contract resources#14128
dorimedini-starkware merged 1 commit into
mainfrom
05-21-starknet_os_initial_test_measure_call_contract_resources

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_add_os_logger_to_runner_output_for_tests to graphite-base/14128 May 21, 2026 13:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch 2 times, most recently from fc51ad3 to 6a4dbd9 Compare May 21, 2026 13:49
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 6a4dbd9 to a5cf1a7 Compare May 21, 2026 14:03
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14128 to 05-21-blockifier_test_utils_add_os_resources_measurement_contract May 21, 2026 14:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from a5cf1a7 to c7c8260 Compare May 24, 2026 06:50

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 4 of 19 files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 130 at r4 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Replace. The second one is the pending hash of v0.14.3.

I assume I should be appending now, for 0.14.4. right?

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2fa8eff. Configure here.

Comment thread crates/blockifier/src/versioned_constants_test.rs Outdated
Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware changed the base branch from main to graphite-base/14128 May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 2fa8eff to 7c93b0f Compare May 29, 2026 14:04

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 4 of 22 files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 131 at r6 (raw file):

            "0x3e98c2d7703b03a7edb73ed7f075f97f1dcbaa8f717cdf6e1a57bf058265473",
            "0x6ecb73d21c7d98ddd4148f5bcd91cc2747c65364245fbf32a63b05cca1685c2",
            "0x59a0052ae80a978ca71126c9774a17c67c19f79b14bb9d1ea96fb77dc6032d8"

0.14.3 is on a separate branch so I should be appending here, correct? @Yoni-Starkware

Code quote:

"0x59a0052ae80a978ca71126c9774a17c67c19f79b14bb9d1ea96fb77dc6032d8"

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 7c93b0f to 74fde47 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14128 to 05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-29-blockifier_test_utils_add_option_to_deploy_from_zero_in_test_accounts to graphite-base/14128 June 1, 2026 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 74fde47 to 21fd6e4 Compare June 1, 2026 10:24

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 22 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on dorimedini-starkware and Yoni-Starkware).


crates/central_systest_blobs/resources/blob_file_generation line 1 at r6 (raw file):

27

What is it?

Code quote:

27

crates/starknet_os_flow_tests/src/os_resources_test.rs line 197 at r6 (raw file):

    test_output.perform_default_validations();

    // Extract syscall resources consumed, per (measurable) syscall.

You're extracting all syscalls.

Suggestion:

per syscall

crates/starknet_os_flow_tests/src/os_resources_test.rs line 223 at r6 (raw file):

            let inner_overhead = if selector.is_calling_syscall() {
                // TODO(Dori): Take opcodes (like blake) into account.
                inner_calls_iter.next().unwrap().resources.vm_resources

Assuming the inner call (if it exists) is a leaf in the call's tree.
Comment about it?

Code quote:

 inner_calls_iter.next().unwrap().resources.vm_resources

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 21fd6e4 to 3a09774 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14128 to main June 2, 2026 10:21

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 3 comments and resolved 2 discussions.
Reviewable status: 21 of 22 files reviewed, 3 unresolved discussions (waiting on yoavGrs).


crates/central_systest_blobs/resources/blob_file_generation line 1 at r6 (raw file):

Previously, yoavGrs wrote…

What is it?

f2f


crates/starknet_os_flow_tests/src/os_resources_test.rs line 197 at r6 (raw file):

Previously, yoavGrs wrote…

You're extracting all syscalls.

Done.


crates/starknet_os_flow_tests/src/os_resources_test.rs line 223 at r6 (raw file):

Previously, yoavGrs wrote…

Assuming the inner call (if it exists) is a leaf in the call's tree.
Comment about it?

Done.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 3a09774 to d24049e Compare June 2, 2026 11:05

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 7 files and all commit messages, and resolved 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 03c4c84 Jun 2, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants