Skip to content

starknet_os: os resources test - add replace_class#14142

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256from
05-23-starknet_os_os_resources_test_-_add_replace_class
Open

starknet_os: os resources test - add replace_class#14142
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256from
05-23-starknet_os_os_resources_test_-_add_replace_class

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches protocol fee/gas constants and OS program hash used for proving; behavior change for replace_class gas billing but scoped to cost alignment and test coverage.

Overview
Adds replace_class to the OS resources regression harness and refreshes its gas/OS cost constants to match measured behavior.

OsResourcesTestContract now invokes replace_class_syscall during __execute__, and ReplaceClass is removed from UNMEASURABLE_SYSCALLS so the flow test compares live OS overhead against versioned constants. ReplaceClass OS steps drop from 106 → 92 in blockifier_versioned_constants_0_14_4.json, with the regression diff file updated accordingly.

OS Cairo sets REPLACE_CLASS_GAS_COST to 10000 (was 10670), the main OS program hash in program_hash.json changes, and the blockifier replace_class positive-flow test expectation for gas_consumed is 13480 (was 14150).

Reviewed by Cursor Bugbot for commit 42b29c1. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch 2 times, most recently from ed548b5 to 8be4f98 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from b11e870 to 61ef5ef Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 8be4f98 to 6da1a91 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from 2144fa8 to 1ba5ff7 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 6da1a91 to 1534107 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from 1ba5ff7 to c190265 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 1534107 to 823c1a8 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from c190265 to fbcb731 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 823c1a8 to 2b48c6b Compare June 2, 2026 10:21

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 5 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 to graphite-base/14142 June 3, 2026 07:57
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 2b48c6b to 1ef8f5d Compare June 8, 2026 10:23
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14142 to 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 June 8, 2026 10:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 1ef8f5d to 42b29c1 Compare June 9, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from e1d301a to 07d79f0 Compare June 9, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants