Skip to content

starknet_os: os resources test - invoke tx calldata factor#14150

Closed
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor
Closed

starknet_os: os resources test - invoke tx calldata factor#14150
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to OS resource regression tests and versioned-constants fee accounting for invoke transactions, with no auth or execution-path logic changes.

Overview
Invoke execute_txs_inner OS costs are now regression-tested for both the fixed overhead and the scaled calldata factor (scaling factor 2), instead of only pinning the constant term and leaving calldata factor as a TODO.

The flow test runs two minimal invokes on the same stable contract—one with shorter calldata and one with an extra calldata felt—and sets constant to the base invoke’s OS scaffolding and calldata_factor.resources to the difference between the two overheads. The checked-in 0.14.4 versioned constants update InvokeFunction’s calldata factor from 11 to 15 steps (still one poseidon_builtin per scaled unit).

Reviewed by Cursor Bugbot for commit 84efb70. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 04d3d51. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 04d3d51 to 5af6585 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch 2 times, most recently from 3e2e6c5 to cb37a07 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch 2 times, most recently from 4a6103f to 5e52dfb Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 22ef08b to 92ed53b Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 5e52dfb to 482f32d Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 92ed53b to cf82050 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 482f32d to 0c314c7 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from cf82050 to abc03de Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 0c314c7 to 4337967 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from abc03de to e0f48d1 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 4337967 to 84efb70 Compare June 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants