Skip to content

starknet_os: os resources test - deploy account tx constant factor#14148

Closed
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_declare_txfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor
Closed

starknet_os: os resources test - deploy account tx constant factor#14148
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_declare_txfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are test-driven updates to OS resource accounting constants; execution paths are unchanged, though incorrect constants could skew fee estimates.

Overview
Extends the execute_txs_inner OS overhead regression test to cover deploy account transactions alongside invoke and declare, using a stable contract and a dedicated __validate_deploy__ hook so validation stays minimal and measurements stay stable.

The test runs a minimal deploy-account tx through the full OS, subtracts blockifier business-logic resources, and writes the resulting constant overhead into DeployAccount in blockifier_versioned_constants_0_14_4.json (steps and builtin counts increase; calldata scaling factor 2 is unchanged). L1 handler remains a TODO.

Reviewed by Cursor Bugbot for commit ff31b35. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from fbfd93e to f4340dd Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch 2 times, most recently from 4a8df3d to dc5adbd Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 25d975a to 96d404c Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from dc5adbd to 67b8cfa Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 67b8cfa to 8ac7b12 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 8ac7b12 to e916599 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch 2 times, most recently from d1652f9 to b73625a Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from e916599 to 49eb712 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 49eb712 to ff31b35 Compare June 2, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants