starknet_os: os resources test - add send_message_to_l1#14143
Conversation
PR SummaryMedium Risk Overview SendMessageToL1 costs are lowered to match measured OS overhead: OS program hashes ( Reviewed by Cursor Bugbot for commit 1cc8b43. Bugbot is set up for automated code reviews on this repo. Configure here. |
191b6ac to
9534bec
Compare
48a7191 to
39edd2e
Compare
9534bec to
ed548b5
Compare
39edd2e to
b4dc505
Compare
ed548b5 to
8be4f98
Compare
b4dc505 to
6d69bf0
Compare
6d69bf0 to
a359fa6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a359fa6. Configure here.
dda5432 to
c91e910
Compare
823c1a8 to
2b48c6b
Compare
c91e910 to
18c656c
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 115 at r2 (raw file):
// send message to l1 syscall. // TODO(Yoni, 1/6/2022): In this case the number of steps depends on the payload size - // consider counting it.
Yes, it should be linear.
I don't know what payload size represents an average cost.
In Python, there is 1 element.
Code quote:
// TODO(Yoni, 1/6/2022): In this case the number of steps depends on the payload size -
// consider counting it.
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yoni-Starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 115 at r2 (raw file):
Previously, yoavGrs wrote…
Yes, it should be linear.
I don't know what payload size represents an average cost.
In Python, there is 1 element.
Oh, you're doing it now, NVM
18c656c to
b7607b6
Compare
2b48c6b to
1ef8f5d
Compare
1ef8f5d to
42b29c1
Compare
b7607b6 to
1cc8b43
Compare


No description provided.