starknet_os: os resources test - add emit event#14136
Conversation
PR SummaryMedium Risk Overview The measurement contract invokes
Reviewed by Cursor Bugbot for commit f00371f. Bugbot is set up for automated code reviews on this repo. Configure here. |
08dbf97 to
f7fd3a3
Compare
844ec16 to
00a30cb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ee3ec7. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ee3ec7. Configure here.
3ee3ec7 to
8a9154e
Compare
3b1142c to
5a9f77f
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 2 comments and resolved 2 discussions.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on yoavGrs and Yoni-Starkware).
crates/starknet_os_flow_tests/src/os_resources_test.rs line 220 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
You can run this tx with trivial fee bounds and make this test a bit cleaner
fixed properly in the next PR. your way could also work but I don't want to break if for some reason we want to avoid trivial resource bounds
crates/starknet_os_flow_tests/src/os_resources_test.rs line 227 at r2 (raw file):
Previously, yoavGrs wrote…
IMO you can omit these lines.
The while loop ensures that ifEmitEventis a measurable syscall, it appears only once more.
this is fixed properly in the next PR
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Yoni-Starkware).
8a9154e to
fa3879f
Compare
5a9f77f to
b949893
Compare
fa3879f to
b72cdb7
Compare
b949893 to
7dd4dcd
Compare
7dd4dcd to
87b5bdd
Compare
b72cdb7 to
2c1bfd1
Compare
|
Artifacts upload workflows: |
2c1bfd1 to
8929f71
Compare
8929f71 to
f00371f
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 3 of 7 files reviewed, 3 unresolved discussions (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).
crates/blockifier/src/transaction/execution_flavors_test.rs line 910 at r5 (raw file):
) + u64_from_usize(get_const_syscall_resources(SyscallSelector::EmitEvent).n_steps) + 3527)
3527 == 3588 - 61, where 61 is the old step cost of EmitEvent
Code quote:
3527
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 5 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).


No description provided.