Skip to content

starknet_os: os resources test - extract setup_test_builder#14145

Open
dorimedini-starkware wants to merge 1 commit into
graphite-base/14145from
05-24-starknet_os_os_resources_test_-_extract_setup_test_builder
Open

starknet_os: os resources test - extract setup_test_builder#14145
dorimedini-starkware wants to merge 1 commit into
graphite-base/14145from
05-24-starknet_os_os_resources_test_-_extract_setup_test_builder

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented May 24, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor in os_resources_test.rs with no production or runtime behavior changes.

Overview
Refactors OS resources flow tests by pulling shared harness setup into setup_test_builder and an OsResourcesTestSetup return type.

The helper centralizes deploying and funding the OS-resources account contract, forcing step-tracking via min_sierra_version_for_sierra_gas, declaring/deploying the stable measurement contract, and advancing to the next block. test_fee_transfer_syscalls and test_os_resources_regression now call it instead of duplicating that logic; the regression test passes Some(&raw_vc) so block context versioned constants are asserted against the loaded VC, while the fee-transfer test uses None.

Reviewed by Cursor Bugbot for commit 21103d8. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from e669ac7 to f5a424e Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from d2589c6 to 15ddac2 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from f5a424e to ac5afa2 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch 2 times, most recently from 72ceed8 to e0bcdfa Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from e0bcdfa to 668f39a Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 41c9f3d to 985e731 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 668f39a to 8cf1830 Compare June 1, 2026 08:37
Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 985e731 to 485162f Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 8cf1830 to 2625ae9 Compare June 1, 2026 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_secp_syscalls branch from 485162f to e935403 Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 2625ae9 to 98b3648 Compare June 2, 2026 10:21

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 98b3648. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 8, 2026 10:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from 98b3648 to a20c3ab Compare June 8, 2026 10:25
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14145 to 05-23-starknet_os_os_resources_test_-_add_secp_syscalls June 8, 2026 10:25
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_extract_setup_test_builder branch from a20c3ab to 21103d8 Compare June 8, 2026 11:59
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_add_secp_syscalls to graphite-base/14145 June 9, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants