Skip to content

starknet_os: resources test - declare#14415

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
06-08-starknet_os_resources_test_-_declare
Open

starknet_os: resources test - declare#14415
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factorfrom
06-08-starknet_os_resources_test_-_declare

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

dorimedini-starkware commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test and versioned-constants fixture updates only; no production execution-path logic changes.

Overview
Extends the OS execute_txs_inner resource regression test to cover Declare transactions alongside the existing paired Invoke measurements.

The test now runs a third tx: a Cairo1 declare of the fixed DATA_GAS_ACCOUNT artifacts (so declare cost stays stable and is not tied to the editable measurement contract). It records the OS scaffolding overhead as a constant TransactionType::Declare entry and asserts the latest blockifier_versioned_constants_0_14_4.json matches—Declare n_steps rises from 3523 to 3938 and range_check from 72 to 92.

The deployable for resource measurement account gains a stub __validate_declare__ entry point with updated Sierra/CASM so account validation paths stay aligned with declare flows used in the suite.

Reviewed by Cursor Bugbot for commit fa76fed. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from 124e469 to de0acc0 Compare June 8, 2026 11:02
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_constant_factor branch from 7f07092 to fb53fd2 Compare June 8, 2026 11:59
@dorimedini-starkware dorimedini-starkware force-pushed the 06-08-starknet_os_resources_test_-_declare branch from de0acc0 to fa76fed Compare June 8, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants