Skip to content

starknet_os: os resources test - create fixed deployable account#14173

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account
Jun 1, 2026
Merged

starknet_os: os resources test - create fixed deployable account#14173
dorimedini-starkware merged 1 commit into
mainfrom
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only artifacts and static contract loaders; no production OS or execution logic changes in this diff.

Overview
Adds a fixed, precompiled deployable account contract for Starknet OS flow tests so deployment resource measurement can use stable class hashes and bytecode instead of rebuilding contracts each run.

The contract (deployable_for_resource_measurement) is a minimal Cairo 1 account with standard __validate__ / __validate_deploy__ / __execute__, plus constructor, external, and L1 handler entry points that take variable-length Span<felt252> calldata. Sierra and CASM JSON artifacts (compiler v2.17.0) are checked in, and .gitattributes marks those JSON files as -diff like other large test resources.

special_contracts.rs exposes lazy-loaded DEPLOYABLE_FOR_RESOURCE_MEASUREMENT_CONTRACT_SIERRA and _CASM (currently #[expect(dead_code)]) and refactors existing loaders to use a shared CompilerContractClass import alias.

Reviewed by Cursor Bugbot for commit 26732a9. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch 2 times, most recently from 6266963 to b45291c Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch 2 times, most recently from 7facbbd to bf48e42 Compare May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from b45291c to 91c50c1 Compare May 25, 2026 15:37

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from bf48e42 to fea1c50 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 91c50c1 to 92f7798 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_os_resources_test_-_library_call to graphite-base/14173 May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 92f7798 to 6593ca5 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14173 to main May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 6593ca5 to 99778d3 Compare June 1, 2026 08:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 99778d3 to 26732a9 Compare June 1, 2026 09:47

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 5 files and all commit messages.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on yoavGrs and Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit bd190a2 Jun 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants