Skip to content

starknet_os: os resources test - add 3 more syscalls#14138

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-23-starknet_os_os_resources_test_-_add_3_more_syscalls
Jun 7, 2026
Merged

starknet_os: os resources test - add 3 more syscalls#14138
dorimedini-starkware merged 1 commit into
mainfrom
05-23-starknet_os_os_resources_test_-_add_3_more_syscalls

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes OS program hashes, syscall gas costs, and fee-related regression numbers for 0.14.4; incorrect constants would affect gas accounting and proving compatibility.

Overview
Extends the OS resources regression harness so GetBlockHash, GetClassHashAt, and GetExecutionInfo are exercised in os_resources_test_contract and dropped from the unmeasurable-syscall list in os_resources_test.

That measurement pass refreshes 0.14.4 syscall OS step counts and related Sierra gas constants (GET_BLOCK_HASH, GET_EXECUTION_INFO, etc.), bumps OS / virtual OS program hashes in Cairo constants, program_hash.json, and versioned constants, and updates blockifier syscall/transaction tests plus central systest blob fixtures to match lower reported gas.

Reviewed by Cursor Bugbot for commit 716761a. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 700672b to 4bdb20a Compare June 2, 2026 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 4bdb20a to c0e4a42 Compare June 2, 2026 15:17
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls branch from 18f0bed to 21be0eb Compare June 2, 2026 15:17

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 2 comments.
Reviewable status: 2 of 8 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).


crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 104 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Same OS impl though

Done.


crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 85 at r3 (raw file):

Previously, yoavGrs wrote…

Does whether the block exists or not affect the resource usage?

hmmm... you are correct that this block hash is missing... apparently we only set hashes in the range [CURRENT_BLOCK_NUMBER - BLOCK_HASH_HISTORY_RANGE, CURRENT_BLOCK_NUMBER - 10]. I'll set it to a number in this range

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 5 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).


crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 85 at r3 (raw file):

Previously, dorimedini-starkware wrote…

hmmm... you are correct that this block hash is missing... apparently we only set hashes in the range [CURRENT_BLOCK_NUMBER - BLOCK_HASH_HISTORY_RANGE, CURRENT_BLOCK_NUMBER - 10]. I'll set it to a number in this range

It doesn't change the resources. Nice.

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls branch from 21be0eb to 98571a1 Compare June 3, 2026 07:17
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from c0e4a42 to 5762c7a Compare June 3, 2026 07:17

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 6 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).


crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 85 at r3 (raw file):

Previously, yoavGrs wrote…

It doesn't change the resources. Nice.

I didn't run the update-expect.
in general, I only start updating the values when the PR is the next one into main, because it can take 15 minutes to do the update rounds and if I maintain it throughout the stack, every gt modify -a will hit conflicts in every single PR up the stack...

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls branch from 98571a1 to cc6f1b8 Compare June 3, 2026 07:51
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 5762c7a to 990a5a3 Compare June 3, 2026 07:51

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls to graphite-base/14138 June 7, 2026 13:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 990a5a3 to 9543067 Compare June 7, 2026 14:30
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14138 to main June 7, 2026 14:30
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 9543067 to 276c0d4 Compare June 7, 2026 14:42
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 276c0d4 to 716761a Compare June 7, 2026 14:46

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 3 of 14 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 277 at r6 (raw file):

                "n_memory_holes": 0,
                "builtin_instance_counter": {
                    "range_check_builtin": 3

@Yoni-Starkware I'm not sure why this measurement is different, any ideas?

Code quote:

"range_check_builtin": 3

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 12 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).


crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 277 at r6 (raw file):

Previously, dorimedini-starkware wrote…

@Yoni-Starkware I'm not sure why this measurement is different, any ideas?

Why changed assert_le -> assert_nn_le

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 7, 2026
Merged via the queue into main with commit a215c31 Jun 7, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants