starknet_os: os resources test - add 3 more syscalls#14138
Conversation
PR SummaryMedium Risk Overview That measurement pass refreshes 0.14.4 syscall OS step counts and related Sierra gas constants ( Reviewed by Cursor Bugbot for commit 716761a. Bugbot is set up for automated code reviews on this repo. Configure here. |
0d44efb to
cd7ac82
Compare
818a408 to
e55a063
Compare
700672b to
4bdb20a
Compare
4bdb20a to
c0e4a42
Compare
18f0bed to
21be0eb
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 2 comments.
Reviewable status: 2 of 8 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 104 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Same OS impl though
Done.
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 85 at r3 (raw file):
Previously, yoavGrs wrote…
Does whether the block exists or not affect the resource usage?
hmmm... you are correct that this block hash is missing... apparently we only set hashes in the range [CURRENT_BLOCK_NUMBER - BLOCK_HASH_HISTORY_RANGE, CURRENT_BLOCK_NUMBER - 10]. I'll set it to a number in this range
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 5 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 85 at r3 (raw file):
Previously, dorimedini-starkware wrote…
hmmm... you are correct that this block hash is missing... apparently we only set hashes in the range
[CURRENT_BLOCK_NUMBER - BLOCK_HASH_HISTORY_RANGE, CURRENT_BLOCK_NUMBER - 10]. I'll set it to a number in this range
It doesn't change the resources. Nice.
yoavGrs
left a comment
There was a problem hiding this comment.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yoni-Starkware).
21be0eb to
98571a1
Compare
c0e4a42 to
5762c7a
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 6 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).
crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 85 at r3 (raw file):
Previously, yoavGrs wrote…
It doesn't change the resources. Nice.
I didn't run the update-expect.
in general, I only start updating the values when the PR is the next one into main, because it can take 15 minutes to do the update rounds and if I maintain it throughout the stack, every gt modify -a will hit conflicts in every single PR up the stack...
98571a1 to
cc6f1b8
Compare
5762c7a to
990a5a3
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yoni-Starkware).
990a5a3 to
9543067
Compare
cc6f1b8 to
39d2dc3
Compare
|
Artifacts upload workflows: |
9543067 to
276c0d4
Compare
276c0d4 to
716761a
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 3 of 14 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware, yoavGrs, and Yoni-Starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 277 at r6 (raw file):
"n_memory_holes": 0, "builtin_instance_counter": { "range_check_builtin": 3
@Yoni-Starkware I'm not sure why this measurement is different, any ideas?
Code quote:
"range_check_builtin": 3
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 12 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json line 277 at r6 (raw file):
Previously, dorimedini-starkware wrote…
@Yoni-Starkware I'm not sure why this measurement is different, any ideas?
Why changed assert_le -> assert_nn_le
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

No description provided.