docs(changedetection): sync template standards#330
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds a single mapping entry for the ChangesPlayground Config Mapping
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 4, 2026
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add the canonical changedetection.validate helper and validate.yaml gate - validate ingress, Gateway API, External Secrets, and selector label override combinations before rendering broken manifests - add helm-unittest coverage for validation failures and align NOTES.txt with numbered sections ## Validation - make template-standards-check CHART=changedetection - helm unittest charts/changedetection - helm lint --strict charts/changedetection - make standards-check CHART=changedetection - make validate-chart CHART=changedetection TIMEOUT=900: FULLY VALIDATED (15 layers) - make site-sync-check CHART=changedetection - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#330 (merged) Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Helm chart validation to fail fast on common misconfigurations (ingress hosts, gateway parent references, external secret store settings, and restricted selector label overrides). * **Bug Fixes** * Improved Ingress rendering so `spec.rules[].host` is omitted when no host is provided, while still producing a valid catch-all rule. * **Documentation** * Refreshed post-install notes with clearer numbered sections and reorganized routing/external secrets guidance. * **Tests** * Added validation and Ingress test coverage for both success cases and specific expected failure messages. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
This was referenced Jul 6, 2026
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related
Validation
Summary by CodeRabbit