Skip to content

docs(changedetection): sync template standards#330

Merged
mberlofa merged 1 commit into
mainfrom
docs/changedetection-template-standards-sync
Jul 3, 2026
Merged

docs(changedetection): sync template standards#330
mberlofa merged 1 commit into
mainfrom
docs/changedetection-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • register changedetection in the site sync playground registry
  • keep the playground/site sync gate aligned with the chart validation PR

Related

Validation

  • make site-sync-check CHART=changedetection
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features
    • Added support for the changedetection chart in the playground, so it now appears in chart selection and filtering.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 63120b17-2d55-49b5-a04a-22dac909bf07

📥 Commits

Reviewing files that changed from the base of the PR and between 045d259 and 2b181d0.

📒 Files selected for processing (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

This change adds a single mapping entry for the changedetection chart to the siteSyncPlaygroundConfigs object in src/pages/playground.astro, pointing it to src/data/playground-configs.ts so it is included when building configured chart slugs and filtering playground charts.

Changes

Playground Config Mapping

Layer / File(s) Summary
Register changedetection chart config
src/pages/playground.astro
Added changedetection entry to siteSyncPlaygroundConfigs mapping to src/data/playground-configs.ts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is related to the PR, though it is broader than the actual registry update.
Description check ✅ Passed The description covers summary, related issue, and validation, with only minor template-format gaps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/changedetection-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa merged commit 365449a into main Jul 3, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/changedetection-template-standards-sync branch July 3, 2026 09:38
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add the canonical changedetection.validate helper and validate.yaml
gate
- validate ingress, Gateway API, External Secrets, and selector label
override combinations before rendering broken manifests
- add helm-unittest coverage for validation failures and align NOTES.txt
with numbered sections

## Validation
- make template-standards-check CHART=changedetection
- helm unittest charts/changedetection
- helm lint --strict charts/changedetection
- make standards-check CHART=changedetection
- make validate-chart CHART=changedetection TIMEOUT=900: FULLY VALIDATED
(15 layers)
- make site-sync-check CHART=changedetection
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#330 (merged)
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added Helm chart validation to fail fast on common misconfigurations
(ingress hosts, gateway parent references, external secret store
settings, and restricted selector label overrides).
* **Bug Fixes**
* Improved Ingress rendering so `spec.rules[].host` is omitted when no
host is provided, while still producing a valid catch-all rule.
* **Documentation**
* Refreshed post-install notes with clearer numbered sections and
reorganized routing/external secrets guidance.
* **Tests**
* Added validation and Ingress test coverage for both success cases and
specific expected failure messages.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant