Skip to content

docs(cloudflared): sync playground coverage#333

Merged
mberlofa merged 1 commit into
mainfrom
docs/cloudflared-template-standards-sync
Jul 6, 2026
Merged

docs(cloudflared): sync playground coverage#333
mberlofa merged 1 commit into
mainfrom
docs/cloudflared-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add cloudflared to the Helm values playground eligibility map required by the chart sync check

Validation

  • make site-sync-check CHART=cloudflared
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#653
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Added support for the cloudflared chart in the playground chart list, making it available alongside other supported charts.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 39250ff6-5638-434f-918e-416137b9a1cf

📥 Commits

Reviewing files that changed from the base of the PR and between 618591a and d9e4027.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

The change adds the cloudflared chart slug to siteSyncPlaygroundConfigs in src/pages/playground.astro, expanding the set of site-synced slugs used when building playgroundCharts.

Changes

Playground Config Allowlist Update

Layer / File(s) Summary
Extend site-sync config allowlist
src/pages/playground.astro
Adds cloudflared to siteSyncPlaygroundConfigs, expanding the chart slugs included in playgroundCharts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by adding a chart slug to the same allowlist used by playgroundCharts.
  • helmforgedev/site#330: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro with another slug mapped to src/data/playground-configs.ts.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the cloudflared playground coverage sync change and matches the main code update.
Description check ✅ Passed The description includes a clear summary and validation steps; it is mostly complete despite not using the template's checkbox format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/cloudflared-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add centralized cloudflared values validation through
templates/validate.yaml
- add helm-unittest coverage for tunnel, ESO, metrics, PDB, and
selector-label guardrails
- align NOTES.txt with the HelmForge numbered operational sections

## Validation
- make template-standards-check CHART=cloudflared
- helm unittest charts/cloudflared
- helm lint --strict charts/cloudflared
- make standards-check CHART=cloudflared
- make validate-chart CHART=cloudflared TIMEOUT=900: FULLY VALIDATED (16
layers)
- make site-sync-check CHART=cloudflared
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#333
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added Helm chart runtime validation to prevent deployments with
invalid tunnel, external secrets, metrics/monitoring, replica/PDB, and
selector label configurations.
  * Added a rendering-time validation manifest hook.
* **Documentation**
* Reorganized Helm installation notes into numbered sections, including
updated metrics behavior and new high-availability details.
* **Bug Fixes**
* Improved failure detection and clearer error messages for common
misconfigurations (tunnel credentials/URLs, external secrets, metrics vs
monitoring, replica/PDB, selector label conflicts).
* **Tests**
* Expanded validation test coverage for invalid configuration
combinations and expected error messages.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/cloudflared-template-standards-sync branch from 618591a to d9e4027 Compare July 6, 2026 10:48
@mberlofa mberlofa merged commit 9dd1f07 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/cloudflared-template-standards-sync branch July 6, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant