docs(cloudflared): sync playground coverage#333
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change adds the ChangesPlayground Config Allowlist Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add centralized cloudflared values validation through templates/validate.yaml - add helm-unittest coverage for tunnel, ESO, metrics, PDB, and selector-label guardrails - align NOTES.txt with the HelmForge numbered operational sections ## Validation - make template-standards-check CHART=cloudflared - helm unittest charts/cloudflared - helm lint --strict charts/cloudflared - make standards-check CHART=cloudflared - make validate-chart CHART=cloudflared TIMEOUT=900: FULLY VALIDATED (16 layers) - make site-sync-check CHART=cloudflared - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#333 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Helm chart runtime validation to prevent deployments with invalid tunnel, external secrets, metrics/monitoring, replica/PDB, and selector label configurations. * Added a rendering-time validation manifest hook. * **Documentation** * Reorganized Helm installation notes into numbered sections, including updated metrics behavior and new high-availability details. * **Bug Fixes** * Improved failure detection and clearer error messages for common misconfigurations (tunnel credentials/URLs, external secrets, metrics vs monitoring, replica/PDB, selector label conflicts). * **Tests** * Expanded validation test coverage for invalid configuration combinations and expected error messages. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
618591a to
d9e4027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#653
Issue: helmforgedev/charts#633
Summary by CodeRabbit