Skip to content

docs(discount-bandit): sync network policy coverage#337

Open
mberlofa wants to merge 1 commit into
mainfrom
docs/discount-bandit-template-standards-sync
Open

docs(discount-bandit): sync network policy coverage#337
mberlofa wants to merge 1 commit into
mainfrom
docs/discount-bandit-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Discount Bandit to the playground chart registry
  • document the canonical networkPolicy.egress.extraEgress value in the chart page configuration reference

Validation

  • make site-sync-check CHART=discount-bandit
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#658
Issue: helmforgedev/charts#633

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR expands the Networking configuration reference table in the discount-bandit chart documentation to cover additional NetworkPolicy ingress and egress parameters, and adds a 'discount-bandit' entry to the site-sync playground configs allowlist.

Changes

Discount Bandit Docs and Playground Update

Layer / File(s) Summary
Networking docs and playground allowlist update
src/pages/docs/charts/discount-bandit.mdx, src/pages/playground.astro
The Networking table now documents additional networkPolicy.ingress.* and networkPolicy.egress.* parameters, and discount-bandit is added to siteSyncPlaygroundConfigs.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and clearly matches the docs-focused Discount Bandit changes, including network policy documentation updates.
Description check ✅ Passed The description covers the summary and validation steps, but it does not follow the template headings exactly and omits a Related Issue section.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/discount-bandit-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- align Discount Bandit NOTES with the numbered HelmForge operational
sections
- add canonical `networkPolicy.egress.extraEgress` support while
preserving existing `extraTo` peers
- document the new NetworkPolicy egress surface in values schema and
helm-unittest coverage

## Validation
- make template-standards-check CHART=discount-bandit
- helm unittest charts/discount-bandit
- helm lint --strict charts/discount-bandit
- make standards-check CHART=discount-bandit
- make validate-chart CHART=discount-bandit TIMEOUT=900: FULLY VALIDATED
(19 layers)
- make site-sync-check CHART=discount-bandit
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#337
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added support for `networkPolicy.egress.extraEgress`, allowing custom
full egress rules (including `to`/ports) to be appended to the rendered
NetworkPolicy.

* **Documentation**
* Reformatted and reorganized the chart notes into a clearer,
markdown-style layout.

* **Tests**
* Added a test to confirm `extraEgress` is correctly rendered in the
NetworkPolicy output.

* **Chores**
* Expanded `values.schema.json` and updated `values.yaml` to document
the new `networkPolicy` egress options.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant