Skip to content

docs(ddns-updater): sync playground coverage#336

Merged
mberlofa merged 1 commit into
mainfrom
docs/ddns-updater-template-standards-sync
Jul 6, 2026
Merged

docs(ddns-updater): sync playground coverage#336
mberlofa merged 1 commit into
mainfrom
docs/ddns-updater-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add ddns-updater to the playground chart config mapping after the chart template behavior update

Validation

  • npm run lint
  • npm run format:check
  • npm run build
  • make site-sync-check CHART=ddns-updater
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#657
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Added support for the ddns-updater chart in the playground, allowing it to appear in the available chart list when applicable.
  • Bug Fixes
    • Improved chart inclusion behavior so playground results now reflect the configured site sync entries more accurately.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: de0be810-7eab-4254-a6c0-3fcc201bb253

📥 Commits

Reviewing files that changed from the base of the PR and between 9ae2561 and b19a411.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

This change adds the ddns-updater chart slug to the siteSyncPlaygroundConfigs allowlist in src/pages/playground.astro, so it can be included in the computed playgroundCharts list.

Changes

Playground config allowlist update

Layer / File(s) Summary
Add ddns-updater slug
src/pages/playground.astro
Adds ddns-updater to siteSyncPlaygroundConfigs, making it eligible for playgroundCharts selection.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro to include a new chart slug.
  • helmforgedev/site#330: Updates the same allowlist registry in src/pages/playground.astro with another chart slug entry.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly names the ddns-updater playground coverage sync and matches the single main change.
Description check ✅ Passed The description includes a summary, validation commands, and issue/chart references, which is mostly complete for this template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/ddns-updater-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- align ddns-updater NOTES with the numbered HelmForge template standard
- add centralized chart validation for ingress host requirements and
reserved selector label overrides
- preserve hostless ingress rendering for catch-all ingress rules and
cover it with unittest coverage

## Validation
- make template-standards-check CHART=ddns-updater
- helm unittest charts/ddns-updater
- helm lint --strict charts/ddns-updater
- make standards-check CHART=ddns-updater
- make validate-chart CHART=ddns-updater TIMEOUT=900: FULLY VALIDATED
(14 layers)
- make site-sync-check CHART=ddns-updater
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#336
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Updated Helm install notes into a structured, step-by-step guide with
access instructions, expanded configuration details, security settings,
and grouped resources/troubleshooting.
* **Bug Fixes**
* Improved ingress rendering to omit the host field when no host is
provided, enabling clean hostless/catch-all rules.
* **Bug Fixes / Validation**
* Added Helm-time validation to fail fast when ingress hosts are missing
and to block `podLabels` from overriding chart selector labels.
* **Tests**
* Added ingress and validation test coverage, including hostless
behavior and expected validation failure messages.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/ddns-updater-template-standards-sync branch from 9ae2561 to b19a411 Compare July 6, 2026 11:20
@mberlofa mberlofa merged commit 4516851 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/ddns-updater-template-standards-sync branch July 6, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant