Skip to content

docs(metrics-server): sync template standards updates#359

Open
mberlofa wants to merge 2 commits into
mainfrom
docs/metrics-server-template-standards-sync
Open

docs(metrics-server): sync template standards updates#359
mberlofa wants to merge 2 commits into
mainfrom
docs/metrics-server-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Document networkPolicy.extraEgress for Metrics Server.
  • Add Metrics Server playground NetworkPolicy controls, including custom egress CIDR and port.
  • Register Metrics Server in the playground sync allowlist.

Related

Validation

  • npm run lint
  • npm run format:check
  • npm run build
  • make site-sync-check CHART=metrics-server
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features

    • Added Network Policy options for the metrics-server playground configuration, including controls for egress rules, DNS and kubelet egress, CIDR-based access, and TCP port settings.
    • Enabled metrics-server to appear in the playground’s site-sync chart selection.
  • Documentation

    • Updated the metrics-server docs to reflect the latest Network Policy settings and added the new extraEgress value to the configuration reference.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bab3cd21-105f-43af-8541-d133ddc90e87

📥 Commits

Reviewing files that changed from the base of the PR and between 059749b and e23761c.

📒 Files selected for processing (2)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/metrics-server.mdx
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/metrics-server.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/data/playground-configs.ts

📝 Walkthrough

Walkthrough

Adds a Network Policy field group to the metrics-server playground config, registers the chart for site-sync playground configs, and updates the metrics-server docs example and values table.

Changes

Metrics-server Network Policy support

Layer / File(s) Summary
Network Policy playground config and wiring
src/data/playground-configs.ts, src/pages/playground.astro
Adds a collapsible Network Policy section gated by networkPolicy.enabled, with DNS/kubelet egress toggles and extra egress CIDR/TCP port fields; registers the metrics-server slug in siteSyncPlaygroundConfigs.
Metrics-server docs update for NetworkPolicy
src/pages/docs/charts/metrics-server.mdx
Updates the NetworkPolicy example to use allowDNS casing and add extraEgress: [], plus a new networkPolicy.extraEgress row in the Values table.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#322: Also extends src/pages/playground.astro’s site-sync chart mapping to include a new chart slug.
  • helmforgedev/site#330: Also updates src/pages/playground.astro to register an additional chart slug for playground site-sync filtering.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is related to the docs and playground sync changes, though it is broader than the main egress-path update.
Description check ✅ Passed The description covers the summary, validation steps, and related issue, but it does not follow the template's exact section formatting.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/metrics-server-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa

mberlofa commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Synced the Metrics Server chart value-path change from helmforgedev/charts#681:

  • Updated docs from networkPolicy.extraEgress to networkPolicy.egress.extraEgress.
  • Updated the playground config keys for the extra egress CIDR and port fields.

Validation completed:

  • make site-sync-check CHART=metrics-server passed on this branch.
  • npm run format:check passed.
  • npm run lint passed.
  • npm run build passed.
  • make release-check REPO=site passed.
  • make attribution-check REPO=site passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant