Skip to content

docs(alfio): sync template standards#323

Merged
mberlofa merged 1 commit into
mainfrom
docs/alfio-template-standards-sync
Jul 6, 2026
Merged

docs(alfio): sync template standards#323
mberlofa merged 1 commit into
mainfrom
docs/alfio-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • register alfio in the site sync playground registry
  • keep the playground/site sync gate aligned with the chart validation PR

Validation

  • make site-sync-check CHART=alfio
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#643
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Expanded the playground’s sync/config workflow to include an additional chart, improving what appears in the filtered playground list.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The siteSyncPlaygroundConfigs mapping in src/pages/playground.astro was extended with an alfio entry pointing to src/data/playground-configs.ts, changing which charts are included in the playground’s filtered list.

Changes

Playground Config Update

Layer / File(s) Summary
Add alfio to sync configs
src/pages/playground.astro
Adds an alfio entry to siteSyncPlaygroundConfigs, mapping it to src/data/playground-configs.ts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also extends src/pages/playground.astro by adding another chart slug to siteSyncPlaygroundConfigs.
  • helmforgedev/site#330: Also updates siteSyncPlaygroundConfigs in src/pages/playground.astro to register an additional chart.

Related Issues: None specified

Suggested labels: None specified

Suggested reviewers: None specified

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the PR’s sync-related registry update, though it is broader than the specific alfio change.
Description check ✅ Passed The description covers the summary, validation, and related issue, but it should more closely follow the template headings.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/alfio-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa force-pushed the docs/alfio-template-standards-sync branch from df8da7b to b774a8f Compare July 4, 2026 19:08
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add the canonical alfio.validate helper and validate.yaml gate
- fail fast for invalid external database settings when PostgreSQL
subchart is disabled
- fail fast for enabled ingress without hosts
- reject podLabels that override immutable selector labels
- add helm-unittest coverage for validation failures

## Validation
- node scripts/charts/template-standards-check.js --chart alfio --json
- helm unittest charts/alfio
- helm lint --strict charts/alfio
- make standards-check CHART=alfio
- make validate-chart CHART=alfio TIMEOUT=1200: FULLY VALIDATED (13
layers)
- make site-sync-check CHART=alfio
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#323
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added Helm chart render-time validation that stops rendering when
required external database and ingress settings are missing, and
prevents conflicting `podLabels` overrides.

* **Tests**
* Added a chart validation test suite with positive and negative
assertions for external DB requirements, ingress host requirements, and
disallowed label overrides.
* Updated deployment tests to ensure the external database password is
provided via a referenced secret.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/alfio-template-standards-sync branch from b774a8f to 0b95efe Compare July 6, 2026 09:43
@mberlofa mberlofa merged commit aa0c1ac into main Jul 6, 2026
5 checks passed
@mberlofa mberlofa deleted the docs/alfio-template-standards-sync branch July 6, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant