docs(alfio): sync template standards#323
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe ChangesPlayground Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Related Issues: None specified Suggested labels: None specified Suggested reviewers: None specified 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
df8da7b to
b774a8f
Compare
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add the canonical alfio.validate helper and validate.yaml gate - fail fast for invalid external database settings when PostgreSQL subchart is disabled - fail fast for enabled ingress without hosts - reject podLabels that override immutable selector labels - add helm-unittest coverage for validation failures ## Validation - node scripts/charts/template-standards-check.js --chart alfio --json - helm unittest charts/alfio - helm lint --strict charts/alfio - make standards-check CHART=alfio - make validate-chart CHART=alfio TIMEOUT=1200: FULLY VALIDATED (13 layers) - make site-sync-check CHART=alfio - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#323 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Helm chart render-time validation that stops rendering when required external database and ingress settings are missing, and prevents conflicting `podLabels` overrides. * **Tests** * Added a chart validation test suite with positive and negative assertions for external DB requirements, ingress host requirements, and disallowed label overrides. * Updated deployment tests to ensure the external database password is provided via a referenced secret. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
b774a8f to
0b95efe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#643
Issue: helmforgedev/charts#633
Summary by CodeRabbit