Skip to content

docs(langflow): sync template standards updates#348

Open
mberlofa wants to merge 1 commit into
mainfrom
docs/langflow-template-standards-sync
Open

docs(langflow): sync template standards updates#348
mberlofa wants to merge 1 commit into
mainfrom
docs/langflow-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Sync Langflow chart docs with the NetworkPolicy egress behavior from fix(langflow): align template standards charts#670.
  • Document networkPolicy.dnsEgressPeers and the default kube-system/kube-dns DNS peer selection.
  • Add Langflow Network Policy controls to the playground config.

Related

Validation

  • make site-sync-check CHART=langflow
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features

    • Added Langflow to the playground chart selection.
    • Added new configuration options for network policy and DNS egress in the playground.
    • Expanded the chart documentation with clearer guidance on persistence, ingress behavior, and network policy settings.
  • Bug Fixes

    • Updated ingress class selection options for a smoother configuration experience.
    • Clarified database and scaling requirements for multi-replica deployments.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 28857ac6-47dc-4be1-936d-1c92dd8ff13e

📥 Commits

Reviewing files that changed from the base of the PR and between 28633a8 and 487dccd.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/langflow.mdx
  • src/pages/playground.astro
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/langflow.mdx
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/pages/playground.astro
  • src/data/playground-configs.ts

📝 Walkthrough

Walkthrough

Updates olivetin playground configuration with a reordered ingress class selector and new NetworkPolicy fields, updates langflow documentation and examples, and adds langflow to the playground site sync configs list.

Changes

Playground configs and docs

Layer / File(s) Summary
Olivetin playground config updates
src/data/playground-configs.ts
Reorders the ingress class options to include an empty value, and adds collapsed networkPolicy.enabled sections with DNS-related fields and a database egress port field defaulting to 5432.
Langflow documentation and playground sync
src/pages/docs/charts/langflow.mdx, src/pages/playground.astro, src/data/playground-configs.ts
Updates the pinned Langflow image tag, expands configuration reference coverage for persistence, ingress, and network policy, adds a DNS egress example, clarifies scaling text, adds langflow to siteSyncPlaygroundConfigs, and adds a Langflow DNS egress playground section.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by extending siteSyncPlaygroundConfigs with another chart slug.
  • helmforgedev/site#330: Also changes src/pages/playground.astro to make a new chart slug eligible for playground filtering.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the Langflow docs sync, but it is vague and doesn't clearly describe the network policy and playground changes. Rename it to mention the Langflow NetworkPolicy docs and playground config updates, e.g. 'docs(langflow): sync NetworkPolicy egress docs and playground config'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the main summary, validation commands, and related chart PR, so it is mostly complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/langflow-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/data/playground-configs.ts (1)

4493-4550: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Langflow playground entry has no NetworkPolicy field despite doc coverage.

langflow.mdx (same PR) documents networkPolicy.enabled and networkPolicy.extraEgress in detail, and the PR objectives claim NetworkPolicy controls are exposed for Langflow in the playground registry. This langflow config block is unchanged and still only has General and Ingress sections — no NetworkPolicy field group to let users preview/toggle this documented behavior.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/data/playground-configs.ts` around lines 4493 - 4550, The langflow
playground config is missing the documented NetworkPolicy controls, so the
registry entry still only exposes General and Ingress settings. Update the
langflow block in the playground config to add a NetworkPolicy field group
alongside the existing sections, wiring in the same networkPolicy.enabled and
networkPolicy.extraEgress controls described in langflow.mdx so users can
preview and toggle them from the playground.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/data/playground-configs.ts`:
- Around line 4493-4550: The langflow playground config is missing the
documented NetworkPolicy controls, so the registry entry still only exposes
General and Ingress settings. Update the langflow block in the playground config
to add a NetworkPolicy field group alongside the existing sections, wiring in
the same networkPolicy.enabled and networkPolicy.extraEgress controls described
in langflow.mdx so users can preview and toggle them from the playground.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a9a17a0-ede6-4771-9640-a210e3e815e3

📥 Commits

Reviewing files that changed from the base of the PR and between 365449a and eded28b.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/langflow.mdx
  • src/pages/playground.astro

@mberlofa mberlofa force-pushed the docs/langflow-template-standards-sync branch from 28633a8 to 487dccd Compare July 4, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant