fix(langflow): align template standards#670
Open
mberlofa wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
area:docs
area:schema
area:templates
area:tests
area:values
chart:langflow
📝 WalkthroughWalkthroughThis PR updates the Langflow Helm chart by bumping the default image tag to 1.10.1, centralizing validation, making ingress class rendering conditional, adding NetworkPolicy egress support, and expanding the chart README and install notes. ChangesLangflow chart validation, networking, and label fixes
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
Contributor
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 75.757576% |
✅ Security posture acceptable.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7346f16d05
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/langflow/templates/networkpolicy.yaml`:
- Line 3: The network policy template currently gates the baseline Egress rules
on .Values.networkPolicy.extraEgress being non-empty, so an empty list renders
ingress-only policy. Update charts/langflow/templates/networkpolicy.yaml so the
default DNS/HTTPS egress rules are always included whenever networkPolicy is
enabled, and treat extraEgress as additive rather than a شرط for rendering
Egress. Add or adjust a test around the NetworkPolicy rendering path to cover
the empty-list case and verify egress is still present.
In `@charts/langflow/templates/NOTES.txt`:
- Around line 12-19: The runtime env hints in NOTES are hardcoded and can become
stale when app.env or extraEnv overrides those names. Update the NOTES template
to render LANGFLOW_SAVE_DB_IN_CONFIG_DIR and LANGFLOW_OPEN_BROWSER from the same
values source used by the chart, or remove those hints entirely if they cannot
be derived reliably. Use the NOTES template and the app.env/extraEnv rendering
logic as the reference points when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a3c6519a-2a4d-4ba7-9e27-0a27c0a440fa
📒 Files selected for processing (12)
charts/langflow/README.mdcharts/langflow/templates/NOTES.txtcharts/langflow/templates/_helpers.tplcharts/langflow/templates/deployment.yamlcharts/langflow/templates/ingress.yamlcharts/langflow/templates/networkpolicy.yamlcharts/langflow/templates/validate.yamlcharts/langflow/tests/networkpolicy_test.yamlcharts/langflow/tests/templates_test.yamlcharts/langflow/tests/validation_test.yamlcharts/langflow/values.schema.jsoncharts/langflow/values.yaml
mberlofa
force-pushed
the
fix/langflow-template-standards
branch
from
7346f16 to
e36676b
Compare
mberlofa
force-pushed
the
fix/langflow-template-standards
branch
from
e36676b to
7959594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkPolicy.enabled=true, with scoped configurable DNS peers, built-in HTTPS allowance, and additivenetworkPolicy.extraEgress.Related
Validation
helm template test charts/langflow --set networkPolicy.enabled=true | rg -n "policyTypes|Egress|kube-system|kube-dns|port: 53|port: 443"helm unittest charts/langflow(20 tests, 6 suites)make template-standards-check CHART=langflownode scripts/charts/validate-chart.js --chart langflow --no-k3dmake validate-chart CHART=langflow TIMEOUT=900(FULLY VALIDATED, 17 layers)make site-sync-check CHART=langflowmake release-check REPO=charts(expected GR-077 post-merge release warning)make attribution-check REPO=chartsSummary by CodeRabbit
networkPolicyDNS allow-listing viadnsEgressPeers.networkPolicy.extraEgressto append additional outbound rules after the built-in DNS and HTTPS allowances.ingressClassNameis now omitted when unset or intentionally blank.1.10.1.