docs(docmost): sync playground coverage#338
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds ChangesPlayground Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add the canonical `docmost.validate` helper expected by template standards - keep the existing validation behavior and messages by delegating `templates/validate.yaml` to the helper ## Validation - make template-standards-check CHART=docmost - helm unittest charts/docmost - helm lint --strict charts/docmost - make standards-check CHART=docmost - make validate-chart CHART=docmost TIMEOUT=900: FULLY VALIDATED (18 layers) - make site-sync-check CHART=docmost - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#338 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved Helm chart configuration validation to catch invalid replica and storage settings before deployment. * Prevents multi-replica deployments with local storage, ensures required local storage options are provided, and enforces required S3 bucket details and credentials when using S3. * Centralized validation logic so misconfigurations fail consistently and clearly during chart rendering. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
3cf4d0c to
f709706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#659
Issue: helmforgedev/charts#633
Summary by CodeRabbit
docmostchart, making it available in more filter results when browsing stable or supported charts.