Skip to content

docs(docmost): sync playground coverage#338

Merged
mberlofa merged 1 commit into
mainfrom
docs/docmost-template-standards-sync
Jul 6, 2026
Merged

docs(docmost): sync playground coverage#338
mberlofa merged 1 commit into
mainfrom
docs/docmost-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Docmost to the playground chart registry required by site sync

Validation

  • make site-sync-check CHART=docmost
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#659
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Expanded the playground’s chart selection to include the docmost chart, making it available in more filter results when browsing stable or supported charts.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d4002059-bb3b-439c-a97b-729dcd3414aa

📥 Commits

Reviewing files that changed from the base of the PR and between 3cf4d0c and f709706.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

Adds docmost to siteSyncPlaygroundConfigs in src/pages/playground.astro, making that chart slug eligible for the playground’s filtered chart list.

Changes

Playground Config Update

Layer / File(s) Summary
Add docmost to playground configs
src/pages/playground.astro
Adds the docmost slug to siteSyncPlaygroundConfigs, including it in the playground’s chart filtering.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by adding chart slugs to siteSyncPlaygroundConfigs.
  • helmforgedev/site#330: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro with another chart slug for the same filtering path.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the playground coverage sync for Docmost.
Description check ✅ Passed The description includes a summary, validation steps, and issue references, which is sufficient for this non-blog change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/docmost-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add the canonical `docmost.validate` helper expected by template
standards
- keep the existing validation behavior and messages by delegating
`templates/validate.yaml` to the helper

## Validation
- make template-standards-check CHART=docmost
- helm unittest charts/docmost
- helm lint --strict charts/docmost
- make standards-check CHART=docmost
- make validate-chart CHART=docmost TIMEOUT=900: FULLY VALIDATED (18
layers)
- make site-sync-check CHART=docmost
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#338
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved Helm chart configuration validation to catch invalid replica
and storage settings before deployment.
* Prevents multi-replica deployments with local storage, ensures
required local storage options are provided, and enforces required S3
bucket details and credentials when using S3.
* Centralized validation logic so misconfigurations fail consistently
and clearly during chart rendering.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/docmost-template-standards-sync branch from 3cf4d0c to f709706 Compare July 6, 2026 11:42
@mberlofa mberlofa merged commit a4dec8f into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/docmost-template-standards-sync branch July 6, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant