docs(memos): sync template standards updates#349
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdates the olivetin playground config to add an empty Ingress Class option and a new NetworkPolicy section with a Database Egress Port field. Expands memos configuration docs for Ingress and NetworkPolicy, and registers memos in the playground site-sync mapping. ChangesPlayground Config and Documentation Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/data/playground-configs.ts (1)
8140-8146: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winMemos ingress class options lack the empty option now documented in memos.mdx.
The updated
memos.mdxdocuments settingingress.ingressClassName: ""to omitspec.ingressClassName, mirroring the pattern already used forapacheand nowolivetin(options: ['', ...]). Thememosentry here still only offers['traefik', 'nginx'], so playground users can't exercise the documented behavior.♻️ Proposed fix
{ label: 'Ingress Class', key: 'ingress.ingressClassName', type: 'select', default: 'traefik', - options: ['traefik', 'nginx'], + options: ['', 'traefik', 'nginx'], description: 'Ingress controller class', },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/playground-configs.ts` around lines 8140 - 8146, The Memos ingress class selector is missing the empty option that is now documented, so update the playground config entry for ingress.ingressClassName to include an empty choice alongside the existing traefik and nginx values. Use the existing pattern from the apache and olivetin config entries in playground-configs.ts, keeping the same label, key, and description while extending the options list so users can select "" and omit spec.ingressClassName.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/data/playground-configs.ts`:
- Around line 8140-8146: The Memos ingress class selector is missing the empty
option that is now documented, so update the playground config entry for
ingress.ingressClassName to include an empty choice alongside the existing
traefik and nginx values. Use the existing pattern from the apache and olivetin
config entries in playground-configs.ts, keeping the same label, key, and
description while extending the options list so users can select "" and omit
spec.ingressClassName.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7368d274-6320-4af0-abbf-bec0881de11f
📒 Files selected for processing (3)
src/data/playground-configs.tssrc/pages/docs/charts/memos.mdxsrc/pages/playground.astro
|
Synced the Memos NetworkPolicy docs with helmforgedev/charts#671. What changed:
Validation:
|
Summary
Validation
Chart PR: helmforgedev/charts#671
Issue: helmforgedev/charts#633
Summary by CodeRabbit
New Features
olivetinchart playground with an expanded “Ingress Class” selector (including an empty choice).networkPolicy.enabled, including “Database Egress Port” (default5432).memosin the set of charts eligible for site-synced playground behavior.Documentation
extraEgressinteracts with egress isolation and DNS egress.