docs(chiefonboarding): sync template standards#331
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds ChangesPlayground Chart Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
340d1b6 to
bcf4d68
Compare
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add the canonical chiefonboarding.validate helper and validate.yaml gate - fail fast for incomplete external PostgreSQL, missing ingress rules, and selector label overrides - preserve hostless catch-all Ingress support by omitting spec.rules[].host when not configured - add helm-unittest coverage for validation paths and catch-all Ingress rendering ## Validation - make template-standards-check CHART=chiefonboarding - helm unittest charts/chiefonboarding - helm lint --strict charts/chiefonboarding - make standards-check CHART=chiefonboarding - make validate-chart CHART=chiefonboarding TIMEOUT=1200: FULLY VALIDATED (13 layers) - make site-sync-check CHART=chiefonboarding - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#331 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Ingress rules now omit the `host` field when no host is provided, enabling catch-all routing. * **New Features** * Added render-time validation for external database settings, ingress host configuration, and `podLabels` to prevent selector label overrides. * **Tests** * Added tests for catch-all ingress rendering and for the expected validation failure messages under misconfiguration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: MergeCheck <mergecheck@example.invalid>
bcf4d68 to
3425e73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#651
Issue: helmforgedev/charts#633
Summary by CodeRabbit