Skip to content

docs(chiefonboarding): sync template standards#331

Merged
mberlofa merged 1 commit into
mainfrom
docs/chiefonboarding-template-standards-sync
Jul 6, 2026
Merged

docs(chiefonboarding): sync template standards#331
mberlofa merged 1 commit into
mainfrom
docs/chiefonboarding-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • register chiefonboarding in the site sync playground registry
  • keep the playground/site sync gate aligned with the chart validation PR

Validation

  • make site-sync-check CHART=chiefonboarding
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#651
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Added an additional chart to the playground, making it available for browsing when its slug is present in the configured chart list, even if it is not marked as stable.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d63ff288-c4a6-48e3-b565-b30668d2b6eb

📥 Commits

Reviewing files that changed from the base of the PR and between bcf4d68 and 3425e73.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

Adds chiefonboarding to siteSyncPlaygroundConfigs in playground.astro, allowing that chart slug to be included in playgroundCharts without requiring stable maturity.

Changes

Playground Chart Config Update

Layer / File(s) Summary
Add chiefonboarding config entry
src/pages/playground.astro
Adds chiefonboarding to siteSyncPlaygroundConfigs, which lets it bypass the maturity === 'stable' filter for playground chart inclusion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by adding a chart slug to the shared playground config mapping.
  • helmforgedev/site#330: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro to include another chart slug.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the chiefonboarding registry sync change, though it is broader than the specific code update.
Description check ✅ Passed The description covers the summary, validation steps, and issue reference, and only slightly deviates from the template format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/chiefonboarding-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa force-pushed the docs/chiefonboarding-template-standards-sync branch from 340d1b6 to bcf4d68 Compare July 3, 2026 09:51
mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add the canonical chiefonboarding.validate helper and validate.yaml
gate
- fail fast for incomplete external PostgreSQL, missing ingress rules,
and selector label overrides
- preserve hostless catch-all Ingress support by omitting
spec.rules[].host when not configured
- add helm-unittest coverage for validation paths and catch-all Ingress
rendering

## Validation
- make template-standards-check CHART=chiefonboarding
- helm unittest charts/chiefonboarding
- helm lint --strict charts/chiefonboarding
- make standards-check CHART=chiefonboarding
- make validate-chart CHART=chiefonboarding TIMEOUT=1200: FULLY
VALIDATED (13 layers)
- make site-sync-check CHART=chiefonboarding
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#331
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Ingress rules now omit the `host` field when no host is provided,
enabling catch-all routing.
* **New Features**
* Added render-time validation for external database settings, ingress
host configuration, and `podLabels` to prevent selector label overrides.
* **Tests**
* Added tests for catch-all ingress rendering and for the expected
validation failure messages under misconfiguration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/chiefonboarding-template-standards-sync branch from bcf4d68 to 3425e73 Compare July 6, 2026 10:28
@mberlofa mberlofa merged commit ea2a7d7 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/chiefonboarding-template-standards-sync branch July 6, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant