Skip to content

fix(chiefonboarding): align template standards#651

Merged
mberlofa merged 1 commit into
mainfrom
fix/chiefonboarding-template-standards
Jul 6, 2026
Merged

fix(chiefonboarding): align template standards#651
mberlofa merged 1 commit into
mainfrom
fix/chiefonboarding-template-standards

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the canonical chiefonboarding.validate helper and validate.yaml gate
  • fail fast for incomplete external PostgreSQL, missing ingress rules, and selector label overrides
  • preserve hostless catch-all Ingress support by omitting spec.rules[].host when not configured
  • add helm-unittest coverage for validation paths and catch-all Ingress rendering

Validation

  • make template-standards-check CHART=chiefonboarding
  • helm unittest charts/chiefonboarding
  • helm lint --strict charts/chiefonboarding
  • make standards-check CHART=chiefonboarding
  • make validate-chart CHART=chiefonboarding TIMEOUT=1200: FULLY VALIDATED (13 layers)
  • make site-sync-check CHART=chiefonboarding
  • make release-check REPO=charts
  • make attribution-check REPO=charts

Site PR: helmforgedev/site#331
Issue: #633

Summary by CodeRabbit

  • Bug Fixes
    • Ingress rules now omit the host field when no host is provided, enabling catch-all routing.
  • New Features
    • Added render-time validation for external database settings, ingress host configuration, and podLabels to prevent selector label overrides.
  • Tests
    • Added tests for catch-all ingress rendering and for the expected validation failure messages under misconfiguration.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Standards Check (GR-079) — PASS

Every changed chart fully passes standards-check.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🟢 Security Scan: chiefonboarding

Framework Score
MITRE + NSA + SOC2 83.333336%

✅ Security posture acceptable.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds render-time chart validation for database, ingress, and pod label settings, wires it through a new validate template, and updates ingress rules so host fields are omitted when unset. It also adds tests for the validation failures and the hostless ingress case.

Changes

Chart validation and ingress host handling

Layer / File(s) Summary
Validation helper template and wiring
charts/chiefonboarding/templates/_helpers.tpl, charts/chiefonboarding/templates/validate.yaml, charts/chiefonboarding/tests/validation_test.yaml
Adds chiefonboarding.validate checks for external database and ingress values plus selector label overrides, renders it from validate.yaml, and covers the validation cases in tests.
Conditional ingress host rendering
charts/chiefonboarding/templates/ingress.yaml, charts/chiefonboarding/tests/ingress_test.yaml
Makes ingress rule host rendering conditional on .host being present and adds a test that asserts host is omitted for catch-all paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the PR’s main goal of bringing the chiefonboarding chart into template-standard compliance.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/chiefonboarding-template-standards

Comment @coderabbitai help to get the list of available commands.

@mberlofa mberlofa force-pushed the fix/chiefonboarding-template-standards branch from fee92dc to 504277d Compare July 4, 2026 16:57
@mberlofa mberlofa merged commit 36326cc into main Jul 6, 2026
18 checks passed
@mberlofa mberlofa deleted the fix/chiefonboarding-template-standards branch July 6, 2026 08:21
mberlofa added a commit to helmforgedev/site that referenced this pull request Jul 6, 2026
## Summary
- register chiefonboarding in the site sync playground registry
- keep the playground/site sync gate aligned with the chart validation
PR

## Validation
- make site-sync-check CHART=chiefonboarding
- npm run lint
- npm run format:check
- npm run build
- make release-check REPO=site
- make attribution-check REPO=site

Chart PR: helmforgedev/charts#651
Issue: helmforgedev/charts#633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added an additional chart to the playground, making it available for
browsing when its slug is present in the configured chart list, even if
it is not marked as stable.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:templates area:tests chart:chiefonboarding Issues related to the chiefonboarding chart size:M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant