fix(chiefonboarding): align template standards#651
Merged
Conversation
Contributor
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
Contributor
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 83.333336% |
✅ Security posture acceptable.
📝 WalkthroughWalkthroughThis PR adds render-time chart validation for database, ingress, and pod label settings, wires it through a new validate template, and updates ingress rules so host fields are omitted when unset. It also adds tests for the validation failures and the hostless ingress case. ChangesChart validation and ingress host handling
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
fee92dc to
504277d
Compare
mberlofa
added a commit
to helmforgedev/site
that referenced
this pull request
Jul 6, 2026
## Summary - register chiefonboarding in the site sync playground registry - keep the playground/site sync gate aligned with the chart validation PR ## Validation - make site-sync-check CHART=chiefonboarding - npm run lint - npm run format:check - npm run build - make release-check REPO=site - make attribution-check REPO=site Chart PR: helmforgedev/charts#651 Issue: helmforgedev/charts#633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added an additional chart to the playground, making it available for browsing when its slug is present in the configured chart list, even if it is not marked as stable. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Site PR: helmforgedev/site#331
Issue: #633
Summary by CodeRabbit
hostfield when no host is provided, enabling catch-all routing.podLabelsto prevent selector label overrides.