Skip to content

docs(tomcat): sync template standards updates#364

Open
mberlofa wants to merge 2 commits into
mainfrom
docs/tomcat-template-standards-sync
Open

docs(tomcat): sync template standards updates#364
mberlofa wants to merge 2 commits into
mainfrom
docs/tomcat-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Document networkPolicy.egress.extraEgress for Tomcat.
  • Correct the documented Tomcat image tag to 11.0.23-jdk17-temurin-noble.
  • Add Tomcat playground allowlist coverage and NetworkPolicy extra egress controls.
  • Keep site docs aligned with fix(tomcat): align template standards charts#686.

Related

Validation

  • npm run lint
  • npm run format:check
  • npm run build
  • make site-sync-check CHART=tomcat
  • make release-check REPO=site
  • make attribution-check REPO=site

Summary by CodeRabbit

  • New Features
    • Added a new Network Policy section for the Tomcat chart, including configurable egress settings and default allowed traffic values.
    • Tomcat is now available in the playground.
  • Documentation
    • Updated the Tomcat chart docs with the latest image tag and added examples for Network Policy egress configuration.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9ad7d693-eeec-4ec7-8fd0-a39f11621dcf

📥 Commits

Reviewing files that changed from the base of the PR and between e9d8850 and ddf4e70.

📒 Files selected for processing (1)
  • src/pages/docs/charts/tomcat.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/docs/charts/tomcat.mdx

📝 Walkthrough

Walkthrough

Adds a Network Policy egress configuration section to the tomcat chart playground config, updates the tomcat documentation with the new image tag and networkPolicy.egress example/table entries, and registers tomcat in the playground chart allowlist.

Changes

Tomcat Network Policy Feature

Layer / File(s) Summary
Network Policy playground config fields
src/data/playground-configs.ts
Adds a networkPolicy.enabled-gated field group with networkPolicy.egress.enabled and extra egress CIDR/port fields.
Tomcat docs update for image tag and network policy
src/pages/docs/charts/tomcat.mdx
Updates the image tag to 11.0.23-jdk17-temurin-noble, adds a networkPolicy.egress example in Production Values, and adds corresponding Values table entries.
Playground registration
src/pages/playground.astro
Adds tomcat to siteSyncPlaygroundConfigs, enabling it in playgroundCharts.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • helmforgedev/site#322: Both PRs modify siteSyncPlaygroundConfigs in src/pages/playground.astro to add new chart entries.
  • helmforgedev/site#330: Both PRs extend siteSyncPlaygroundConfigs with a new chart slug in the same file.

Suggested reviewers: helmforgedev-maintainers

🐰 A rabbit hopped through Tomcat's gate,
Set egress rules to seal its fate,
CIDR blocks and port four-four-three,
Docs updated, playground set free,
A tidy hop, none left to wait.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the Tomcat doc update but is too vague to convey the main change. Use a more specific title like 'docs(tomcat): document networkPolicy.egress and update image tag'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers the summary, related issue, and validation steps; only the template's Quality Gates section is missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/tomcat-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa

mberlofa commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Synced the Tomcat chart documentation clarification from helmforgedev/charts#686:

  • Updated the production NetworkPolicy example to use networkPolicy.egress.extraTo when appending peers to the built-in egress rules.
  • Added networkPolicy.egress.extraTo to the values table alongside extraEgress.

Validation completed:

  • make site-sync-check CHART=tomcat passed on this branch.
  • npm run format:check passed.
  • npm run lint passed.
  • npm run build passed.
  • make release-check REPO=site passed.
  • make attribution-check REPO=site passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant