fix(tomcat): align template standards#686
Conversation
github-actions
Bot
added
area:docs
area:schema
area:templates
area:tests
area:values
chart:tomcat
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds ChangesNetworkPolicy extraEgress feature
NOTES.txt restructuring
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 94.94949% |
✅ Security posture acceptable.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dbaa7dc58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/tomcat/README.md (1)
82-82: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider clarifying
extraTovsextraEgressdistinction.Both
extraTo(appends peers to base egress rules) andextraEgress(adds standalone complete rules) are documented separately, but the Production Notes bullet doesn't clarify when to use one over the other, which could confuse users who need only additional peers rather than an independent rule.Also applies to: 107-107
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/tomcat/README.md` at line 82, Clarify the Production Notes guidance in the README by explaining the difference between networkPolicy.egress.extraTo and networkPolicy.egress.extraEgress: use extraTo in the README’s egress note when users want to append additional peers to the existing base egress rules, and reserve extraEgress for defining standalone custom egress rules. Update the bullet near the networkPolicy.egress section so users can choose the right option without ambiguity, and make the same clarification in the other referenced note as well.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@charts/tomcat/README.md`:
- Line 82: Clarify the Production Notes guidance in the README by explaining the
difference between networkPolicy.egress.extraTo and
networkPolicy.egress.extraEgress: use extraTo in the README’s egress note when
users want to append additional peers to the existing base egress rules, and
reserve extraEgress for defining standalone custom egress rules. Update the
bullet near the networkPolicy.egress section so users can choose the right
option without ambiguity, and make the same clarification in the other
referenced note as well.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 16a9c508-b18f-4b7f-902e-1dade2c0cdc7
📒 Files selected for processing (8)
charts/tomcat/README.mdcharts/tomcat/templates/NOTES.txtcharts/tomcat/templates/networkpolicy.yamlcharts/tomcat/tests/operations_test.yamlcharts/tomcat/tests/test-connection.yamlcharts/tomcat/tests/testconnection_test.yamlcharts/tomcat/values.schema.jsoncharts/tomcat/values.yaml
💤 Files with no reviewable changes (1)
- charts/tomcat/tests/testconnection_test.yaml
mberlofa
force-pushed
the
fix/tomcat-template-standards
branch
from
2dbaa7d to
396abf6
Compare
mberlofa
force-pushed
the
fix/tomcat-template-standards
branch
from
396abf6 to
d1854d2
Compare
|
Addressed the still-valid CodeRabbit review-body nitpick:
Validation completed after the fix:
This CodeRabbit note was in the review summary body, not as a separate resolvable review thread, so there was no thread ID to resolve. |
1 participant
Summary
templates/testssohelm testremains functionalnetworkPolicy.egress.extraEgresssupport with schema and unit coverageValidation
make validate-chart CHART=tomcat TIMEOUT=900: FULLY VALIDATED (16 layers), including k3d behavioral scenarios for default, gateway-api, hardening, ingress, ip-family-policy, JMX, and standalone.make site-sync-check CHART=tomcatmake release-check REPO=chartspassed with the expected GR-077 post-merge release confirmation warning.make attribution-check REPO=chartsSite PR: helmforgedev/site#364
Issue: #633
Summary by CodeRabbit
networkPolicy.egress.extraEgressto support supplying additional complete NetworkPolicy egress rules.extraEgress, including when base egress is disabled.extraEgressis provided.