Skip to content

docs(cronicle): sync playground coverage#335

Merged
mberlofa merged 1 commit into
mainfrom
docs/cronicle-template-standards-sync
Jul 6, 2026
Merged

docs(cronicle): sync playground coverage#335
mberlofa merged 1 commit into
mainfrom
docs/cronicle-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add cronicle to the Helm values playground eligibility map required by the chart sync check

Validation

  • make site-sync-check CHART=cronicle
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Chart PR: helmforgedev/charts#656
Issue: helmforgedev/charts#633

Summary by CodeRabbit

  • New Features
    • Added support for the cronicle chart in the playground’s sync/config selection, making it available alongside other eligible chart slugs.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 142b529e-11ef-4ff7-91df-b3402fd067b1

📥 Commits

Reviewing files that changed from the base of the PR and between e68c6fd and 744bf24.

📒 Files selected for processing (1)
  • src/pages/playground.astro
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/playground.astro

📝 Walkthrough

Walkthrough

A single-line addition to src/pages/playground.astro adds the cronicle chart slug to siteSyncPlaygroundConfigs, linking it to src/data/playground-configs.ts for playground sync/config eligibility.

Changes

Playground Config Mapping

Layer / File(s) Summary
Add cronicle mapping entry
src/pages/playground.astro
Adds cronicle to siteSyncPlaygroundConfigs, mapping it to src/data/playground-configs.ts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • helmforgedev/site#322: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro with another chart slug.
  • helmforgedev/site#330: Also updates the same playground config mapping logic by adding a different slug entry.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: adding Cronicle to the playground sync coverage.
Description check ✅ Passed The description covers the summary, validation steps, and linked chart issue, which is mostly complete for this template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/cronicle-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

mberlofa added a commit to helmforgedev/charts that referenced this pull request Jul 6, 2026
## Summary
- add centralized cronicle values validation through
templates/validate.yaml
- add helm-unittest coverage for secret, ingress, and selector-label
guardrails
- preserve hostless catch-all Ingress rendering by omitting
spec.rules[].host when unset

## Validation
- make template-standards-check CHART=cronicle
- helm unittest charts/cronicle
- helm lint --strict charts/cronicle
- make standards-check CHART=cronicle
- make validate-chart CHART=cronicle TIMEOUT=900: FULLY VALIDATED (12
layers)
- make site-sync-check CHART=cronicle
- make release-check REPO=charts
- make attribution-check REPO=charts

Site PR: helmforgedev/site#335
Issue: #633

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added render-time chart validation to fail fast on invalid
configuration (e.g., missing required secret settings, missing Ingress
hosts, and conflicting pod label configuration).
* Added support for “hostless” Ingress rules by omitting the `host`
field when no host is provided.
* **Bug Fixes**
* Prevented `podLabels` from overriding the chart’s selector label keys.
* **Tests**
  * Added Ingress coverage for hostless catch-all behavior.
* Added a validation test suite for both passing and failing scenarios.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: MergeCheck <mergecheck@example.invalid>
@mberlofa mberlofa force-pushed the docs/cronicle-template-standards-sync branch from e68c6fd to 744bf24 Compare July 6, 2026 11:10
@mberlofa mberlofa merged commit 12503f0 into main Jul 6, 2026
6 checks passed
@mberlofa mberlofa deleted the docs/cronicle-template-standards-sync branch July 6, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant