Skip to content

docs(flowise): sync startup delay options#344

Open
mberlofa wants to merge 1 commit into
mainfrom
docs/flowise-template-standards-sync
Open

docs(flowise): sync startup delay options#344
mberlofa wants to merge 1 commit into
mainfrom
docs/flowise-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • document Flowise startup delay values used to serialize first-boot queue migrations
  • update Flowise image/default references to 3.1.3
  • enable and correct Flowise playground defaults and values paths

Validation

  • make site-sync-check CHART=flowise
  • npm run lint
  • npm run format:check
  • npm run build
  • make release-check REPO=site
  • make attribution-check REPO=site

Charts PR: helmforgedev/charts#666
Issue: helmforgedev/charts#633

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Playground configuration for the Flowise chart replaces prior general fields with Flowise-specific keys and restructures ingress fields to hosts/paths format, removing the TLS toggle. Flowise is added to the site-sync playground map. Flowise documentation is updated for startup delay settings, queue-mode sequencing guidance, and an image tag bump.

Changes

Flowise playground config and docs

Layer / File(s) Summary
Playground config fields for Flowise
src/data/playground-configs.ts
General field group now uses flowise.* keys (replica count, startup delay, app URL, persistence size); Ingress migrated to ingress.hosts[0].host/paths[0] structure with ingress.tls removed.
Playground site-sync wiring
src/pages/playground.astro
Added flowise entry to siteSyncPlaygroundConfigs, enabling it in playground filtering logic.
Flowise documentation updates
src/pages/docs/charts/flowise.mdx
Queue-mode example updated to single main replica with startupDelaySeconds for both main and worker; image tag bumped to 3.1.3; migration callout and Queue Mode warning updated with first-boot sequencing guidance.

Estimated code review effort: 2 (Simple) | ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and accurately summarizes the main Flowise startup-delay documentation update.
Description check ✅ Passed The description includes a clear summary, validation steps, and linked issue, though it does not follow the template's Quality Gates checklist format.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/flowise-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/data/playground-configs.ts (1)

3726-3783: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Move the Flowise fields out of the n8n config in src/data/playground-configs.ts. The n8n block now defines flowise.* and queue.worker.* keys, while src/pages/playground.astro routes the Flowise slug to chartConfigs.flowise. That leaves Flowise without these controls and pushes invalid values into N8N. Move this General/Queue block under flowise and restore the N8N-specific fields.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/data/playground-configs.ts` around lines 3726 - 3783, The Flowise
General/Queue settings are mistakenly defined under the n8n config, which causes
flowise.* and queue.worker.* values to be applied to the wrong chart. Move this
block from the n8n entry in playground-configs.ts into the flowise entry so
playground.astro can resolve the Flowise slug via chartConfigs.flowise, and
restore the proper N8N-specific fields under n8n instead. Use the existing
General and Queue section names and the flowise/queue.worker field keys to
relocate the controls cleanly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/data/playground-configs.ts`:
- Around line 3726-3783: The Flowise General/Queue settings are mistakenly
defined under the n8n config, which causes flowise.* and queue.worker.* values
to be applied to the wrong chart. Move this block from the n8n entry in
playground-configs.ts into the flowise entry so playground.astro can resolve the
Flowise slug via chartConfigs.flowise, and restore the proper N8N-specific
fields under n8n instead. Use the existing General and Queue section names and
the flowise/queue.worker field keys to relocate the controls cleanly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c33a0221-9602-489e-9a27-47c2c55e193d

📥 Commits

Reviewing files that changed from the base of the PR and between 365449a and 48c094a.

📒 Files selected for processing (3)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/flowise.mdx
  • src/pages/playground.astro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant