Skip to content

docs(jenkins): sync template standards updates#355

Open
mberlofa wants to merge 2 commits into
mainfrom
docs/jenkins-template-standards-sync
Open

docs(jenkins): sync template standards updates#355
mberlofa wants to merge 2 commits into
mainfrom
docs/jenkins-template-standards-sync

Conversation

@mberlofa

@mberlofa mberlofa commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • sync Jenkins chart docs with the template-standards chart update
  • expose networkPolicy.extraEgress in the Jenkins playground controls
  • mark Jenkins as a curated playground config for site-sync tracking

Validation

  • npm run lint
  • npm run format:check
  • npm run build
  • make site-sync-check CHART=jenkins

Related charts PR: helmforgedev/charts#677

Summary by CodeRabbit

  • New Features

    • Added the Jenkins chart to the playground chart selector so it’s now available with other supported charts.
    • Enhanced Jenkins network policy egress configuration with additional optional settings to allow an extra destination CIDR and an extra TCP egress port.
  • Documentation

    • Updated the Jenkins chart “Values” documentation to describe the new egress override/append option and adjusted the values table formatting accordingly.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b50ec52-2ba7-4d16-adbc-eac5edc81f2b

📥 Commits

Reviewing files that changed from the base of the PR and between 86756b3 and 843406c.

📒 Files selected for processing (2)
  • src/data/playground-configs.ts
  • src/pages/docs/charts/jenkins.mdx
✅ Files skipped from review due to trivial changes (1)
  • src/pages/docs/charts/jenkins.mdx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/data/playground-configs.ts

📝 Walkthrough

Walkthrough

Adds Jenkins NetworkPolicy egress fields to the playground config, documents the new networkPolicy.egress.extraEgress value, and registers Jenkins in the playground sync list.

Changes

Jenkins extraEgress configuration

Layer / File(s) Summary
Playground config and registration
src/data/playground-configs.ts, src/pages/playground.astro
Adds Jenkins NetworkPolicy egress field definitions with defaults and includes the jenkins slug in siteSyncPlaygroundConfigs.
Jenkins chart docs
src/pages/docs/charts/jenkins.mdx
Adds a values table row for networkPolicy.egress.extraEgress with default [] and adjusts nearby table formatting.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • helmforgedev/site#322: Also updates src/pages/playground.astro by adding a chart slug to siteSyncPlaygroundConfigs.
  • helmforgedev/site#330: Also extends siteSyncPlaygroundConfigs in src/pages/playground.astro to register another chart slug.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the Jenkins docs sync and playground tracking updates.
Description check ✅ Passed The description includes a clear summary and validation steps, and no blog-discovery section is needed for these files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/jenkins-template-standards-sync

Comment @coderabbitai help to get the list of available commands.

@mberlofa

mberlofa commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Synced this site PR with the Jenkins chart value-path change in helmforgedev/charts#677.

What changed:

  • Updated the Jenkins chart page value reference from networkPolicy.extraEgress to networkPolicy.egress.extraEgress.
  • Updated the playground field keys to generate networkPolicy.egress.extraEgress.

Validation:

  • make site-sync-check CHART=jenkins reports the required artifacts as OK.
  • npm run format:check passed.
  • npm run lint passed.
  • npm run build passed.
  • make release-check REPO=site passed.
  • make attribution-check REPO=site passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant