Skip to content

refactor(crew): adopt shared Metric summaries - #648

Merged
zacjones93 merged 3 commits into
codex/ui-metricfrom
codex/metric-summary-migration
Jul 15, 2026
Merged

refactor(crew): adopt shared Metric summaries#648
zacjones93 merged 3 commits into
codex/ui-metricfrom
codex/metric-summary-migration

Conversation

@zacjones93

@zacjones93 zacjones93 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replaces the three duplicated Crew SummaryMetric helpers with 27 direct Metric.Inset / Metric.Label / Metric.Value compositions
  • preserves the existing three-column grids, visible label/value order, values, background/border treatment, and import/heats workflow state and handlers
  • adds focused semantic coverage for all three consumers plus zero, composed React-node, and long-value cases
  • documents the consumer contract in lat.md

Stack

Validation

  • focused Metric consumer suite: 4/4 passed
  • Crew typecheck: passed
  • changed production files Biome: passed
  • generated UI inventory freshness: passed
  • lat check: passed
  • git diff --check: passed
  • GitNexus staged analysis: low risk, 5 changed files, 0 affected execution flows
  • pre-push monorepo lint: passed (existing warnings only)
  • pre-push monorepo typecheck: 12/12 tasks passed
  • full Crew suite: 3,186 passed; only baseline failures remain (two missing legacy component imports and two stale event-import-tabs label assertions, reproduced on the exact base). A separate XLSX decompression timeout appeared only on one repeat and is known flaky.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf558d77-78ac-4974-82fa-d812c8607f68

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/metric-summary-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

Independent review: LGTM / no blocking findings at exact head 7ecd5ebe6b2569a3cea4204b4514df9381625ec0, stacked on exact base 0ef7159c4dd023e4dd5d9fb437956630d6cf49b8.

Bounded verification:

  • Exactly three Crew source files changed. Each base file had nine SummaryMetric calls plus one local helper; each head file has nine direct Metric.Inset / Metric.Label / Metric.Value pairs. Total: 27 migrated sites and all three helpers removed.
  • Each migrated site now renders a direct dl / dt / dd semantic pair.
  • Labels and value expressions are preserved. Existing responsive grids remain unchanged. Metric.Inset defaults plus border bg-background and label overrides preserve the prior rounded border, background, padding, spacing, muted normal-weight label, and 2xl semibold value presentation.
  • The source diff contains no handler, state, server-function, calculation, or workflow changes.
  • The focused test checks nine pairs per file, exact labels, non-empty values, helper removal, plus zero/ReactNode/long-value ordering. It would fail on the pinned base: each base source has zero direct Metric pairs and still contains its helper.
  • Focused Crew tests passed (4/4), Crew type-check passed, inventory is current, lat check and git diff --check passed.
  • Live review state has no submitted reviews or actionable inline threads; the only prior comment is CodeRabbit skipping the draft. All CI checks are green, and the PR is mergeable.

@zacjones93
zacjones93 merged commit d6316c1 into codex/ui-metric Jul 15, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant