feat(ui): add shared package foundation - #616
Conversation
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (52)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
LGTM — no blocking findings in the stacked diff Independent review covered the Validation repeated on Node 24.15.0 / Corepack pnpm 9.12.1:
Two reviewed non-blockers:
Live state at review time: CI and Git Town succeeded; E2E Tests are still in progress. CodeRabbit was rate-limited and produced no findings or review threads, so it was not treated as approval. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
d6316c1
into
codex/ui-library-foundation
Stack
codex/ui-library-foundationatae63ca98fcodex/ui-package-foundationata0b1e2518main.What changed
@repo/uiwith direct subpath exports forcn,badge,button,card,input,label,separator,skeleton,spinner,table, andtextarea.@repo/ui/styles.css, including package source scanning. Start and Crew import that contract once and retain app-specific keyframes/range styles.@repo/ui/*entry points.lat.md/ui-library.mdfor the package, adapter, styling, Storybook, and test contracts.Scope
The extracted primitive sources are byte-identical between Start and Crew and remain byte-identical to the prior canonical source except for the required package-relative
cnimports. No route files changed. Stateful, overlay, form, and domain components remain app-owned;use-mobileremains app-local because this slice does not require it.Validation
Run with Node
v24.15.0and Corepack pnpm9.12.1:pnpm --filter @repo/ui buildpnpm --filter @repo/ui type-checkpnpm --filter @repo/ui test— 12/12 compatibility and style-contract cases passedpnpm --filter wodsmith-start type-checkpnpm --filter crew type-checkpnpm --filter wodsmith-start build-storybookfoundations-button--default— loaded shared component, meaningful content rendered, no error overlaypnpm --filter wodsmith-start check:ui-inventorypnpm --filter @repo/ui lint— cleanpnpm lint— 9/9 tasks passed (existing repository warnings remain)pnpm type-check— 12/12 tasks passedlat checkgit diff --checkBlockers / limitations
pnpm --filter wodsmith-start buildandpnpm --filter crew buildstop while loading Vite config because this clean worktree does not have generated.alchemy/local/wrangler.jsoncfiles. The base worktree lacks them as well; compilation is not reached.mainSummary by cubic
Introduce
@repo/ui, a shared UI package that hosts base primitives and a Tailwind v4 style contract. Start and Crew now use thin re-exports to keep all existing route imports working.New Features
@repo/uiwith subpath exports:cn,badge,button,card,input,label,separator,skeleton,spinner,table,textarea.@repo/ui/styles.csswith package source scanning.Refactors
cnfrom@repo/ui/*; Storybook imports updated to package entry points.@repo/ui/styles.css; removed duplicated theme config in apps.Written for commit a0b1e25. Summary will update on new commits.