feat(ui): add metric composition - #647
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent review fallback (the external CodeRabbit trigger was blocked by policy): LGTM / no blocking findings at exact head Reviewed the exact diff for the bounded, no-consumer Metric extraction:
Read-only gates passed: PR is mergeable; several CI jobs were still in progress at review time. |
d6316c1
into
codex/empty-state-component-migration
Summary
Metric.Root,Metric.Card, andMetric.Insetdescription-list surfaces to@repo/uiLabel, decorativeIcon,Value, andSupportingparts with finite size and tone variantsWhy
The completed route audit found repeated metric and statistic panels across organizer, admin, and token surfaces. This establishes a presentation-only boundary before any consumer migration, while calculations, grids, fetching, actions, animation, and status vocabulary stay app-owned.
This is stacked on #646 and intentionally contains no route consumers.
Validation
pnpm --filter @repo/ui checkpnpm --filter @repo/ui test— 72 tests passedpnpm --filter @repo/ui type-checkpnpm --filter @repo/ui buildpnpm --filter wodsmith-start type-checkpnpm --filter crew type-checkpnpm --filter wodsmith-start check:ui-inventorypnpm --filter wodsmith-start test:storybook-contrast— static build and both Playwright checks passed across light and dark Canvas storieslat checkgit diff --check 67388dd2a11253fa5c21d5fc4b48a71bad130800..0ef7159c4dd023e4dd5d9fb437956630d6cf49b8Summary by cubic
Adds a new
Metriccomposition to@repo/uiand migrates Crew preview summaries to use it. This standardizes metric semantics while keeping existing layouts and behavior.New Features
Metric.Root,Metric.Card,Metric.Inset.Metric.Label, decorativeMetric.Icon,Metric.Value,Metric.Supporting.Metric.Valuevariants: sizessm|md|lg; tonesneutral|positive|warning|critical.@repo/ui/metric; Start and Crew re-exports with compatibility coverage.Refactors
Metric.Insetin combined import tabs, volunteer import flow, heat import, template preview, and copy-prior-event preview.dl/dt/ddsemantics; compact typography and wrapping retained.SummaryMetrichelpers.Written for commit d6316c1. Summary will update on new commits.