fix(start): add admin dashboard heading hierarchy - #643
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThe admin dashboard now renders semantic ChangesAdmin heading hierarchy
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Independent review of exact base Validated:
|
d6316c1
into
codex/start-admin-sidebar-hydration-fix
What changed
Admin Dashboardtitle as the direct/adminpage's soleh1Quick ActionsandRecent Activityash2sections while preserving their existing visual classesWhy
The exact-head Start coverage pass found that
/adminexposed no semantic headings because its visible titles were genericCardTitledivs. Heading navigation therefore could not identify either the page or its sections.This is deliberately narrow: quick-action destinations, authorization, loaders, dashboard layout, stat cards, and nested admin routes are unchanged.
Validation
Admin DashboardandQuick Actionshad no heading roleslat checkpassedgit diff --checkpassedAuthenticated exact-head browser evidence will be recaptured by the next page-coverage slice on this commit.
mainSummary by cubic
Improved Admin accessibility by setting a correct heading hierarchy on
/adminand fixing Demo Competitions semantics. Introduced a reusableMetricpattern and standardized empty states to unify UI and keep summaries consistent across Start and Crew.Bug Fixes
<h1>(“Admin Dashboard”) with<h2>sections for “Quick Actions” and “Recent Activity”; added route tests and captured admin evidence.<h1>and section headings; added semantics tests.Refactors
@repo/ui/metricand adopted it for summary counts (Crew import previews, heats import, template panel, copy-prior-event); preserved compact typography; added Storybook and thin adapters inapps/*/src/components/ui/metric.tsx.@repo/ui/empty-stateacross organizer components (registration questions, event mapping, invite sources, venues); added focused tests to verify section-level headings and actions.Written for commit d6316c1. Summary will update on new commits.
Summary by CodeRabbit
Accessibility
Tests
Documentation