fix(start): correct demo competition semantics

[zacjones93]

Summary

• make the two demo competition cards level-two sections beneath the single page heading
• make the creation summary a level-three subsection and place workout details inside their owning list item
• add focused DOM regression tests and LAT specs for the heading outline and valid nested-list structure

Scope

• stacked on fix(start): add admin dashboard heading hierarchy #643 (codex/start-admin-dashboard-heading)
• no copy, layout classes, actions, permissions, loader, form, demo creation, or deletion behavior changed
• coverage evidence is intentionally untouched; the following coverage slice will recapture /admin/demo-competitions from this exact head

Verification

• pre-fix focused test: 2/2 failed on missing h2/h3 semantics and invalid list nesting
• focused test: 2/2 passed
• full Start suite: 149 files, 2969 tests passed
• Start type-check passed
• scoped Biome passed
• full pre-push monorepo lint and type-check passed
• lat check passed
• git diff --check passed

Browser verification

Authenticated exact-head recapture is delegated to the immediately following coverage PR, which owns the 16 affected route scenarios and evidence manifests.

GitNexus

The mandated pre-edit impact and pre-commit change detection were attempted after rebuilding the exact worktree index. Both remained unavailable because the shared LadybugDB reader reports a storage-version mismatch (database v42, reader v40); no risk result is claimed.

• main
  • feat(ui): consolidate Storybook and shared UI library #615
    • feat(ui): add shared package foundation #616
      • feat(ui): extract shared form and overlay primitives #617
        • Fix semantic contrast and Storybook Canvas themes #618
          • UI library: add exhaustive page coverage contract #619
            • UI Library Stack 06 — Public Entry Browser Evidence #620
              • Fix dark button hover contrast #621
                • Extract shared feedback and navigation primitives #622
                  • UI Library Stack 08 — Docs and Auxiliary App Evidence #623
                  • feat(ui): add auth entry composition #624
                  • docs(ui): capture protected athlete coverage #625
                  • fix(settings): render profile email outside form field #626
                  • fix(settings): render athlete stats outside form fields #627
                  • fix(series): render movement collection heading #628
                  • feat(ui): add field composition primitives #629
                  • docs(ui): capture Crew organizer coverage #630
                  • refactor(settings): adopt shared field composition #631
                  • fix(crew): contain mobile route layouts #632
                  • fix(judges): compose rotation collection field group #633
                  • docs(ui): capture Crew admin coverage #634
                  • fix(scaling): compose levels field groups #635
                  • fix(registration): compose option field groups #636
                  • feat(ui): add empty state composition #637
                  • fix(crew): align token route accessibility #639
                  • docs(ui): capture Crew token and series coverage #638
                  • fix(start): correct organizer panel semantics #640
                  • refactor(ui): adapt organizer empty states #641
                  • fix(start): stabilize admin sidebar hydration #642
                  • fix(start): add admin dashboard heading hierarchy #643
                  • fix(start): correct demo competition semantics 👈
                  • docs(ui): capture Start admin coverage #645
                  • refactor(ui): compose organizer empty states directly #646
                  • feat(ui): add metric composition #647
                  • refactor(crew): adopt shared Metric summaries #648
                  • refactor(ui): compose Crew preview metrics #649

---

Summary by cubic

Fixes the heading outline and list semantics on Admin > Demo Competitions for better screen‑reader navigation. Also standardizes empty states and introduces a reusable Metric summary pattern used in organizer previews.

• Bug Fixes

  • Use h2 for both card headings under the page h1.
  • Make “What gets created” an h3 and nest the workout list inside its parent list item.
  • Add a route DOM test to guard the heading outline and list structure.

• Refactors

  • Add @repo/ui/metric (with Storybook) and adopt it in import previews and crew templates/copy panels; expose adapters in app barrels.
  • Replace OrganizerEmptyState with @repo/ui/empty-state across organizer components (registration questions, event mapping, invite sources, venues) and add focused DOM tests; capture Start admin coverage artifacts.

^{Written for commit d6316c1. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

@zacjones93, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: be809fe3-8fc4-4459-abfd-f4756e24285c

📥 Commits

Reviewing files that changed from the base of the PR and between 6317e9c and 739ca53.

📒 Files selected for processing (3)

• apps/wodsmith-start/src/routes/admin/demo-competitions/index.tsx
• apps/wodsmith-start/test/routes/admin-demo-competitions-semantics.test.tsx
• lat.md/admin-navigation.md

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/demo-competitions-semantics

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[zacjones93]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[zacjones93]

Independent review: LGTM at 739ca5370f292aac9f20a1ae7389c6e6e07e9e4c.

I verified the exact one-commit diff against codex/start-admin-dashboard-heading (6317e9c1ee0e3f3e566ae323676b987fc0df8666):

• Scope is limited to the demo-competitions route, one focused DOM test file, and two unique LAT test specs.
• The page outline is now one h1, two card h2 sections, then the creation-summary h3; the prior CardTitle visual classes are preserved exactly.
• The workout sublist is a direct child of its owning li, and every direct child of the summary ul is an li.
• No copy, layout classes, actions, permissions, loader/server-function wiring, form state, or create/delete behavior changed; the remaining import movement is formatter-only.
• Focused test passes: 2/2. lat check passes. git diff --check passes. The exact checkout remained clean.

No actionable findings. GitNexus change detection was attempted but the shared reader remains unavailable due to the documented LadybugDB storage-version mismatch (database v42 / reader v40), so I am not claiming graph-derived impact evidence. Remaining CI was still running when this bounded review was posted.