docs(ui): capture Crew token and series coverage - #638
Conversation
WalkthroughThe PR adds deterministic browser evidence for five Crew route groups across desktop and mobile light scenarios, records the captures in a hashed manifest, documents the audit, and promotes matching coverage-plan and ledger entries to verified route-specific coverage. ChangesCrew evidence audit
Estimated code review effort: 3 (Moderate) | ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/ui-library/crew-token-series-coverage-audit.md`:
- Line 15: Clarify the observation date in the audit document’s introductory
capture statement by specifying its timezone; since the manifest timestamps are
UTC on 2026-07-11, either label 2026-07-10 with its intended timezone or update
the date to 2026-07-11 UTC.
In
`@docs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-desktop-light.network.json`:
- Around line 1095-1099: The network artifact inconsistently classifies
/src/styles.css as JavaScript. Update the recorder or normalizer responsible for
generating the artifact to preserve its stylesheet resource type and correct
MIME type, or remove the stale duplicate entry; verify all occurrences are
consistent before using the artifact.
In
`@docs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-mobile-light.a11y.txt`:
- Around line 61-75: The fixture’s assignment date conflicts with the event
window: the schedule in the accessibility snapshot starts on July 10, while
“Event dates” begins July 11. Update the relevant volunteer-token fixture or
accessibility capture so the dates align, or explicitly label the assignment as
pre-event judging if that timing is intentional.
In
`@docs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.a11y.txt`:
- Around line 5-8: The navigation landmarks in the rendered UI are unlabeled,
preventing users from distinguishing global and series navigation. Add distinct
accessible names, such as “Primary navigation” and “Series navigation,” to the
corresponding navigation elements, then recapture the affected accessibility
evidence snapshots.
In
`@docs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.dom.json`:
- Around line 112-118: The checkbox represented in the captured evidence has no
accessible name because both its name and label are empty. Locate the route UI
that renders this checkbox, add a meaningful visible label or programmatic label
association, then regenerate the corresponding evidence so the updated DOM
includes the accessible name.
In
`@docs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.a11y.txt`:
- Around line 12-15: Expose “Volunteer for E2E Crew Demo Throwdown” as an
accessible h1 heading instead of generic text. Locate the page component
rendering this route title and replace or wrap its title element with a semantic
h1, ensuring the rendered accessibility tree reports one heading while
preserving the existing visible text.
In
`@docs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.network.json`:
- Around line 1-1808: The evidence only captures the initial render and does not
demonstrate volunteer signup behavior. Update the network fixture associated
with the volunteer signup flow to include the form submission request and its
resulting success or error response, using the volunteer signup interaction
covered by VolunteerSignupForm; alternatively, relabel the artifact as
initial-render coverage and remove any claim that it validates signup.
In `@lat.md/ui-library.md`:
- Line 405: Replace the Markdown link in the cross-reference sentence with the
repository’s required wiki-link syntax, preserving the existing target document
and link text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5623f000-6cf2-4317-bc02-697e1a86ce3b
⛔ Files ignored due to path filters (10)
docs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-desktop-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-mobile-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-desktop-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-mobile-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-desktop-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-mobile-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-mobile-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.pngis excluded by!**/*.pngdocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-mobile-light.pngis excluded by!**/*.png
📒 Files selected for processing (46)
docs/ui-library/crew-token-series-coverage-audit.mddocs/ui-library/evidence/crew-token-series/2026-07-10/capture-manifest.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-desktop-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-desktop-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-desktop-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-desktop-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-mobile-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-mobile-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-mobile-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/confirm-volunteer-volunteer-token-mobile-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-desktop-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-desktop-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-desktop-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-desktop-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-mobile-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-mobile-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-mobile-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/consent-volunteer-volunteer-token-mobile-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-desktop-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-desktop-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-desktop-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-desktop-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-mobile-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-mobile-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-mobile-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/schedule-volunteer-volunteer-token-mobile-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-desktop-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-mobile-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-mobile-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-mobile-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/series-crew-organizer-mobile-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-desktop-light.network.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-mobile-light.a11y.txtdocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-mobile-light.console.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-mobile-light.dom.jsondocs/ui-library/evidence/crew-token-series/2026-07-10/signup-volunteer-anonymous-mobile-light.network.jsondocs/ui-library/page-coverage-ledger.jsondocs/ui-library/page-coverage-ledger.mddocs/ui-library/page-coverage.plan.jsonlat.md/ui-library.md
|
LGTM — no findings in the docs/evidence-only review of exact base Verified:
Checks passed:
|
|
Follow-up triage after CodeRabbit completed: this supersedes my earlier LGTM. I checked all 8 live comments against exact source/evidence revision Valid docs/evidence fix in PR #638
Valid source/fixture defects requiring a separate preceding fix and recapture
Invalid / no change
Recommendation: do not merge this evidence slice as-is. Land the three source/fixture accessibility/date fixes in a preceding PR, recapture/re-hash the affected evidence, then apply the timezone wording fix in #638 and rerun |
fa99cdd to
8717ec9
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
LGTM on the force-pushed exact range Re-review results:
Checks passed:
|
d6316c1
into
codex/crew-token-accessibility-fixes
Summary
Evidence
Captured from exact base revision
b241ddfc4c3a023669c1604147e3bda3ce8343a5withagent-browser 0.26.0against a fresh isolated local MySQL fixture:/e/:slug/confirm/:token/e/:slug/consent/:token/e/:slug/schedule/:token/e/:slug/volunteer/series/:groupId/crewEach route has desktop 1440×900 and mobile 390×844 light evidence. All 10 scenarios matched their requested URL, viewport, and theme; had no page or console errors, no network responses at or above 400, and no horizontal overflow.
The recapture verifies the accessibility fixes in the preceding stack slice: distinct primary and series navigation landmarks, an
h1on volunteer signup, and assignment/event dates that align in the configured local timezone.The isolated series fixture contains 18 unique Crew demo volunteers. Text artifacts scrub the deterministic fixture token and synthetic emails; no cookies, headers, session values, form values, database URLs, local paths, query values, or production credentials are serialized.
Validation
pnpm check:page-coveragelat checkCoverage after this slice: 350 total / 188 verified / 26 blocked / 136 pending.
Stacked on #639.
main