dotnet: migrate nuget lockfiles to JSON#362278
Conversation
466c5b9 to
f7e34db
Compare
f7e34db to
a91a587
Compare
a91a587 to
4996549
Compare
4996549 to
a29b4ca
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MattSturgeon
left a comment
There was a problem hiding this comment.
Initial minor questions/suggestions. Thanks for working on this, it's looking good from my perspective!
I thought about that, but it looks like release notes have been updated recently for older releases. |
Yeah, I'll try to do that at least for the next SDK updates. |
Thanks, sorry I didn't do it myself but I really don't feel confident to even attempt it. I feel like I'd just end up breaking everything instead 😅 |
In addition to loading nix lockfiles
7856eeb to
2b4190a
Compare
corngood
left a comment
There was a problem hiding this comment.
This all looks good. I added the backport label even though it's almost certainly going to fail the automatic backport. I'm sure some of the treewide changes will backport, but we'll have to do a pass on the rest.
|
Thanks for all the work on this. I'd like to merge it soon, but I just wanted to give anyone a last chance to raise an objection. |
|
The backport will probably have to be done manually. We could also opt to not backport the tree-wide (as the Nix files still work) but that'd necessitate every update backport for dotnet packages to be backported manually. Given that we have nearly perfect QA for this (eval is the same), I don't see a great risk. |
Atemu
left a comment
There was a problem hiding this comment.
Given that every user involved in this thread reacted with a rocket, I think we're good to go ;)
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-362278-to-release-24.11 origin/release-24.11
cd .worktree/backport-362278-to-release-24.11
git switch --create backport-362278-to-release-24.11
git cherry-pick -x 1726304559622bcd20c8e3b7006b41a09bada599 3cc4563eb2f435ddc0da0a4a39f509a7ff7ffb7c bccae9e7c0f234d41ae7c9aebbaaf4f65a27282c c94c5087cc19cc8339e2c4b3e7a1546f6e990fcc 8ea76507abb96c2bdb971b4f7fdadebeea627324 318b37a8d6d1991369606455b4b446a34811f49f 1cd9516969553291792021f1b327f0e2e2775b3c 2b4190a2c20a7d33062f5806b0a0f879082b2340 |
This changes the
buildDotnetModulelockfiles to be JSON instead of Nix.Changes were made in a backwards-compatible fashion, however a warning was added to guide users to migrate to the new format.
Existing in-tree packages were migrated to the new format using a helper script and manual changes for places that didn't have the file directly specified.
cc: @NixOS/dotnet @MattSturgeon @UlyssesZh @TomaSajt @SuperSandro2000 @Atemu
Closes #362182, closes #325053.
Fixes #358025.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.