assetripper: init at 1.1.3

[diadatp]

Description of changes

AssetRipper is a tool for extracting assets from Unity serialized files (CAB-*, *.assets, *.sharedAssets, etc.) and asset bundles (*.unity3d, *.bundle, etc.) and converting them into the native Unity engine format.

https://github.com/AssetRipper/AssetRipper

The patch is is a temporary measure until AssetRipper/AssetRipper#1414 is resolved.

Closes #297634

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[UlyssesZh]

Works for me. Thank you.

[UlyssesZh]

Please rebase on master branch and do this:

Suggested change

	rev = "refs/tags/${finalAttrs.version}";
	tag = finalAttrs.version;

See #355973.

[YoshiRulz]

I've tried rebasing locally and it doesn't build. I think the fault is in Nixpkgs, but I haven't finished bisecting.

[diadatp]

Could you share the build error you are receiving? If it is related to missing lib deps in two of the nuget precompiled libraries, then I have overcome that by including stdenv.cc.cc.lib in the buildInputs as a temporary fix. Would be interested in finding the breaking commit.

[YoshiRulz]

That was it, yeah.

searching for dependencies of /nix/store/y5y38bj32dd71ki3q1k0slnm2jals223-AssetRipper-1.1.3/lib/AssetRipper/libTexture2DDecoderNative.so
    libstdc++.so.6 -> not found!
    libgcc_s.so.1 -> not found!
auto-patchelf: 2 dependencies could not be satisfied
error: auto-patchelf could not satisfy dependency libstdc++.so.6 wanted by /nix/store/y5y38bj32dd71ki3q1k0slnm2jals223-AssetRipper-1.1.3/lib/AssetRipper/libTexture2DDecoderNative.so
error: auto-patchelf could not satisfy dependency libgcc_s.so.1 wanted by /nix/store/y5y38bj32dd71ki3q1k0slnm2jals223-AssetRipper-1.1.3/lib/AssetRipper/libTexture2DDecoderNative.so
auto-patchelf failed to find all the required dependencies.
Add the missing dependencies to --libs or use `--ignore-missing="foo.so.1 bar.so etc.so"`.

Culprit being 687371a (not sure how removing Python from propagated deps means removing libstdc++ but there you go).

[UlyssesZh]

AssetRipper has new releases:

Suggested change

	version = "1.1.3";
	version = "1.1.7";

[YoshiRulz]

Need to bump to .NET 9 for this by the way.

[YoshiRulz]

I tried updating, but fetch-deps wasn't working, and in fact it's not working for 1.1.3 i.e. at cdfc9705b45c8d707d1b39b52df04dee1779ca0b without changes. How did you generate deps.nix?

edit: Opened #363497.

[diadatp]

Good question. The passthru fetch-deps fails for me too. Looking through my shell history, I dropped into a dotnet sdk nix-shell within the project's source and ran approximately the following:

dotnet restore --packages out
nuget-to-nix out > deps.nix

[UlyssesZh]

Note that in comments. Failing to fetch deps automatically would mean that it cannot be updated properly with an update script, and people have to manually handle that, and they need to know how to do that manually by reading the relevant comments.

I am suspecting this be some bug of nuget-to-nix, but considering that currently there is work going on to retire nuget-to-nix (#362278), it may not worth digging into it. However, it would still be good if you can look into this.

[YoshiRulz]

I got 1.1.7 1.1.8 building. YoshiRulz@2dc01fc

[UlyssesZh]

Make sure your commit complies with the relevant conventions. To elaborate, the package name should be all lower-case, and remove the space between "Asset Ripper" in your commit message.

[diadatp]

Took the following steps and squashed.

• Used tag argument instead of rev as per fetchgit{,hub}: add tag argument #355973.
• Included cc libs for autoPatchelf. This may need more consideration as some parts of the source use stdenv.cc.cc.libgcc or null and others use lib.getLib stdenv.cc.cc.
• Added sourceProvenance to package's meta.
• Fixed pname to follow conventions.
• Added a symlink named AssetRipper in bin pointing to the main executable.

[diadatp]

Above push does the following:

Updated meta.mainProgram to reflect symlink.
Fixed bug introduced in fixup due to pname change.
Moved symlink creation to postInstall.

[ToasterUwU]

The "needs upstream fix" tag should be outdated since the nuget-to-nix issue has been closed, right?

Besides that, was this waiting for anything else?

[UlyssesZh]

The "needs upstream fix" tag is not related to nuget-to-nix but is referring to AssetRipper/AssetRipper#1414 (which necessitates the patch in this PR), but yeah, the tag should be removed because that issue is also resolved.

This PR still needs some work: it need to remove the now-unnecessary patch file, and update to the current latest upstream version (and thus .NET 9).

[YoshiRulz]

Rebased and updated

[UlyssesZh]

@YoshiRulz Because @diadatp does not seem to be responding, could you please open a new PR?

[diadatp]

Thank you for taking over @YoshiRulz. Closing this as superseded by #427561.