Skip to content

wasabibackend: 2.0.2.1 -> 2.3.1#361232

Merged
corngood merged 6 commits into
NixOS:masterfrom
gepbird:wasabibackend-2.3.0.0
Oct 2, 2025
Merged

wasabibackend: 2.0.2.1 -> 2.3.1#361232
corngood merged 6 commits into
NixOS:masterfrom
gepbird:wasabibackend-2.3.0.0

Conversation

@gepbird

@gepbird gepbird commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #341848

Tracking: #326335

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Dec 2, 2024
@gepbird gepbird mentioned this pull request Dec 2, 2024
Closed
17 tasks
gepbird
gepbird commented Dec 2, 2024
View reviewed changes
Comment thread nixos/tests/wasabibackend.nix
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 2, 2024
@gepbird

This comment was marked as outdated.

Sign in to view
@gepbird gepbird requested a review from mmahut December 3, 2024 08:26
@gepbird

gepbird commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

cc @Zoriot for testing

@ofborg ofborg Bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 3, 2024
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from 37d3c16 to e355b49 Compare December 11, 2024 09:43
@github-actions github-actions Bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 11, 2024
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from e355b49 to 165a9ba Compare December 11, 2024 09:54
@Zoriot

Zoriot commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

cc @Zoriot for testing

Sorry I don't have any time to test currently.
Maybe I can look into it in the first weekend in the new year.

@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from 165a9ba to 2543a0b Compare December 11, 2024 10:00
@gepbird gepbird changed the title wasabibackend: 2.0.2.1 -> 2.3.0.0 wasabibackend: 2.0.2.1 -> 2.3.1 Dec 11, 2024
@ofborg ofborg Bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 12, 2024
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from 2543a0b to 89148d7 Compare December 18, 2024 16:10
@gepbird

gepbird commented Dec 18, 2024

Copy link
Copy Markdown
Contributor Author

Fixed the merge conflict with #362278

@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from 89148d7 to 07d3fd5 Compare December 18, 2024 16:16
@github-actions github-actions Bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 18, 2024
@ofborg ofborg Bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Dec 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from 07d3fd5 to 4a340dd Compare January 9, 2025 11:08
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 9, 2025
@gepbird

gepbird commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

Fixed merge conflict with #368177

@github-actions github-actions Bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jan 9, 2025
@gepbird

gepbird commented Jan 9, 2025

Copy link
Copy Markdown
Contributor Author

NixOS tests pass, cc @mmahut and @Zoriot if you have some time

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361232

x86_64-linux

✅ 1 package built:
  • wasabibackend

@Zoriot

Zoriot commented Feb 14, 2025

Copy link
Copy Markdown
Contributor

NixOS tests pass, cc @mmahut and @Zoriot if you have some time

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361232

x86_64-linux

✅ 1 package built:

It works fine

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from afd5eb9 to a3fe2f3 Compare March 17, 2025 20:24
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from a3fe2f3 to 6b79002 Compare March 17, 2025 20:31
@github-actions github-actions Bot added the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Mar 17, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from 6b79002 to bb11586 Compare April 11, 2025 09:59
@gepbird gepbird removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 11, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@gepbird gepbird force-pushed the wasabibackend-2.3.0.0 branch from bb11586 to 216707a Compare July 6, 2025 07:29
@gepbird

gepbird commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

Fixed merge conflict with f34483b

@gepbird gepbird removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 6, 2025
@JamieMagee

JamieMagee commented Aug 24, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361232
Commit: 216707af62de56b90fa30f05ef87907a3ae3284d

x86_64-linux

✅ 1 package built:
  • wasabibackend

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 24, 2025
@gepbird

gepbird commented Sep 23, 2025

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 361232
Commit: 216707af62de56b90fa30f05ef87907a3ae3284d (subsequent changes)
Merge: 4967b31820a39eefbb1058ec38390589d7930d2a

Logs: https://github.com/gepbird/nixpkgs-review-gha/actions/runs/17939599841

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-361232-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://gepbird-nixpkgs-review-gha.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  gepbird-nixpkgs-review-gha.cachix.org-1:DXx7aJqJyRfrgSacf/SSVzEaPbrH3lych7ti/zUBol4=
  ' \
  /nix/store/j8q026cbnq8f5n0fs3r4l422c2cx8q0g-wasabibackend-2.3.1

x86_64-linux

✅ 1 package built:
  • wasabibackend

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@gepbird gepbird requested a review from GGG-KILLER September 23, 2025 08:34
GGG-KILLER
GGG-KILLER reviewed Sep 25, 2025
View reviewed changes
Comment thread pkgs/by-name/wa/wasabibackend/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 25, 2025
@gepbird gepbird requested a review from corngood October 1, 2025 21:39
@corngood corngood added this pull request to the merge queue Oct 2, 2025
Merged via the queue into NixOS:master with commit b459ffd Oct 2, 2025
29 of 31 checks passed
@gepbird gepbird deleted the wasabibackend-2.3.0.0 branch October 2, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corngood corngood corngood approved these changes
@mmahut mmahut Awaiting requested review from mmahut
+2 more reviewers
@JamieMagee JamieMagee JamieMagee approved these changes
@GGG-KILLER GGG-KILLER GGG-KILLER approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update request: wasabibackend 2.0.2.1 → 2.1.0

6 participants

@gepbird @Zoriot @JamieMagee @corngood @GGG-KILLER @wegank