[Backport release-24.11] dotnet: migrate nuget lockfiles to JSON#366269
Conversation
|
Would it be reasonable to re-generate json lockfiles for those packages too, and amend the treewide commit?
Had me worried there was an eval difference, but of course it is the infrastructure packages that are actually supposed to be different. |
I sort of don't think it's worth the effort, because it's mostly due to packages that have already made changes that weren't backported. If someone wants to do it though, I have no problem with that. |
That's fair.
If so, probably best to use @GGG-KILLER's script: |
|
If possible I think it'd be better to migrate all lockfiles to JSON to make it easier on people who want to backport changes after our treewide on master. If you'd like I could do that on another PR since I don't have write perms to your branch. |
|
@GGG-KILLER I can always pull your change here if you share it somewhere |
(cherry picked from commit 1726304)
(cherry picked from commit 3cc4563)
In addition to loading nix lockfiles (cherry picked from commit bccae9e)
(cherry picked from commit c94c508)
(cherry picked from commit 8ea7650)
(cherry picked from commit 318b37a)
(cherry picked from commit 1cd9516)
(cherry picked from commit 2b4190a)
|
@corngood I've pushed my changes to https://github.com/GGG-KILLER/nixpkgs/tree/backport-362278-to-release-24.11 I haven't added any changes from #366556 nor #366574 because they're still under review. |
It was causing issues with other hooks and things used in the build for packages so I opted to remove it as it wasn't there to start with.
e78ec6d to
a0485c9
Compare
|
@GGG-KILLER I grabbed your branch, plus those two fixes. Let me know what you think. Thanks for doing the rest of the conversions. |
|
Backport of #362278
I've removed all conflicting packages from the treewide commit.
Cc: @NixOS/dotnet
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.