Skip to content

olympus{,-unwrapped}: init at 25.04.20.01#309327

Merged
pyrox0 merged 2 commits into
NixOS:masterfrom
Petingoso:olympus
Jun 13, 2025
Merged

olympus{,-unwrapped}: init at 25.04.20.01#309327
pyrox0 merged 2 commits into
NixOS:masterfrom
Petingoso:olympus

Conversation

@Petingoso

@Petingoso Petingoso commented May 5, 2024

Copy link
Copy Markdown
Contributor

This is an attempt to package Olympus, a GUI for installing Everest and managing Celeste mods.
This is based on this draft, with the original authors permission.

It is able to launch from the app but for proper use depends on overriding celesteWrapper. See package.nix for details.

I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set.

Needs this which was merged.

Finally, Lönn works as expected, being the installation managed by the program.

Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables, wontfix.

fixes #162887
Closes #295258

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 5, 2024
@4evy

4evy commented May 5, 2024

Copy link
Copy Markdown
Member

I would recommend you have the maintainers commit to be the first one and squash 2eeae0f01e5224dc59e9bd13ebf71d5d9dc77794 into a75b006a4fc0b1a837fcebf04212eafd3218ec88 so you can comply with the Commit Conventions

@Petingoso Petingoso force-pushed the olympus branch 2 times, most recently from d88d90a to 35a7222 Compare May 5, 2024 21:50
@github-actions github-actions Bot added the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label May 5, 2024
@Petingoso

Petingoso commented May 5, 2024

Copy link
Copy Markdown
Contributor Author

Just cherry picked the commits from https://github.com/NixOS/nixpkgs/pull/309026/commits to make the package cleaner
Edit: Commits have been removed as they have been merged.

@Petingoso Petingoso force-pushed the olympus branch 3 times, most recently from e545230 to 5dda007 Compare May 9, 2024 14:06
@github-actions github-actions Bot removed the 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. label May 9, 2024
@IogaMaster

Copy link
Copy Markdown
Contributor

This seems to work great!

@4evy

4evy commented Jul 2, 2024

Copy link
Copy Markdown
Member

Last commit should be squashed

@UlyssesZh

Copy link
Copy Markdown
Member

@ofborg eval

@UlyssesZh

Copy link
Copy Markdown
Member

I think you need to cherry-pick f705702?

@L1Z3

L1Z3 commented Jul 6, 2024

Copy link
Copy Markdown

Just tried this, and Lönn doesn't seem to be able to launch for me:

Expand for log
Error

[love "boot.lua"]:276: utils/filesystem.lua:2: module 'nfd' not found:
no field package.preload['nfd']no file 'selene/selene/lib/nfd.lua'
no file 'selene/selene/lib/nfd/init.lua'
no file 'nfd/nfd.lua'
no file 'olympUI/nfd.lua'
no file 'olympUI/nfd/init.lua'
no file 'nfd.lua'
no file 'nfd/init.lua'
no 'nfd' in LOVE game directories.
no file 'nfd' in LOVE paths.
no file './nfd.lua'
no file '/nix/store/8apx02hrz7bb9pmhcw88dj2k6jgj7pxl-luajit-2.1.1693350652/share/luajit-2.1/nfd.lua'
no file '/usr/local/share/lua/5.1/nfd.lua'
no file '/usr/local/share/lua/5.1/nfd/init.lua'
no file '/nix/store/8apx02hrz7bb9pmhcw88dj2k6jgj7pxl-luajit-2.1.1693350652/share/lua/5.1/nfd.lua'
no file '/nix/store/8apx02hrz7bb9pmhcw88dj2k6jgj7pxl-luajit-2.1.1693350652/share/lua/5.1/nfd/init.lua'
no file '/nix/store/z64mi9bhk1ypkl1znq9h4a3yf60500p1-nfd-22.12/lib/lua/5.1/nfd.so'
no file '/nix/store/77bibyn8ar44jfp2g3hk607jh4xaa0xj-lua5.1-subprocess-bfa8e9/lib/lua/5.1/nfd.so'
no file '/nix/store/bds733hnlwi1nmx4j2q9ipw8im5wc386-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/nfd.so'


Traceback

[love "callbacks.lua"]:228: in function 'handler'
[C]: in function 'error'
[C]: in function 'xpcall'
[C]: in function 'xpcall'

@Petingoso

Copy link
Copy Markdown
Contributor Author

Huh I think I didn't put it as a runtime input, I'm checking if that might be the issue.

@Petingoso

Copy link
Copy Markdown
Contributor Author

Just tried this, and Lönn doesn't seem to be able to launch for me:
Expand for log

I figured it out, when I removed the patch from nfd I was using "nfd" instead of lua51Packages.nfd, meaning I wasn't installing lua modules.
I'll push the fix right now

@L1Z3

L1Z3 commented Jul 7, 2024

Copy link
Copy Markdown

Works great now, thanks!

@IogaMaster IogaMaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks just started using Loenn

kylelovestoad pushed a commit to kylelovestoad/nixos-dotfiles that referenced this pull request Jul 15, 2024
@L1Z3

L1Z3 commented Jul 21, 2024

Copy link
Copy Markdown

Can be bumped to latest commit hash (5f3e40687eb825c57021f52d83a3bc9a82c04bdb) (which has official version number 24.07.06.02 according to the Azure Pipeline page.)

@Petingoso

Copy link
Copy Markdown
Contributor Author

I'll just check if stuff works fine and if all's good I'll edit the PR then.

@Petingoso

Petingoso commented Jul 22, 2024

Copy link
Copy Markdown
Contributor Author

Not sure if its reproduceable for anyone else but going from 6b4ceee45b51b913cf1d50bfb3ae645b21bba4f1 to 8f6e3ec1ab520904b1e0429ac194541d68a897b5 ( the following commit) gives an error relating to luajit-request.luajit-request.init. I'm trying to figure out what might be the issue but it doesn't seem to be making sense.

EDIT: it seems to be missing luajit-request? I dont see why it should be called from that commit

@L1Z3

L1Z3 commented Jul 22, 2024

Copy link
Copy Markdown

No, I don't get that error on commit 8f6e3ec1ab520904b1e0429ac194541d68a897b5 or on the latest commit. On both commits, it builds and runs fine for me. Are you doing something within Olympus that's causing the error to happen?

@Petingoso

Copy link
Copy Markdown
Contributor Author

No, I don't get that error on commit 8f6e3ec1ab520904b1e0429ac194541d68a897b5 or on the latest commit. On both commits, it builds and runs fine for me. Are you doing something within Olympus that's causing the error to happen?

I'm simply going from

      rev = "6b4ceee45b51b913cf1d50bfb3ae645b21bba4f1";
      fetchSubmodules = true; # Required. See upstream's README.
      hash = "sha256-FtvTELf8EZCkoAmMbgwxftxXOzdXy0P69RRMyPlRXUA=";

to

      rev = "5f3e40687eb825c57021f52d83a3bc9a82c04bdb";
      fetchSubmodules = true; # Required. See upstream's README.
      hash = "sha256-aSE0g2YzmFnbSRB8QZ9B+H1HCn92HZqKunVtbdn7oQc=";

and just launching the binary gives me an error. Are you bumping the revision in another way?

Details
pre-initializing
cwd:	/nix/store/x1lzrlzjp8mwy7qj0s2yhfz7kkbb5wyg-olympus-24.04.23.02/lib/olympus
src:	/nix/store/x1lzrlzjp8mwy7qj0s2yhfz7kkbb5wyg-olympus-24.04.23.02/lib/olympus
storageDir:	/home/petnix/.config/Olympus
luajit-request not loaded
module 'luajit-request.luajit-request.init' not found:
	no field package.preload['luajit-request.luajit-request.init']
	no 'luajit-request/luajit-request/init' in LOVE game directories.
	no file 'luajit-request/luajit-request/init' in LOVE paths.
	no file './luajit-request/luajit-request/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/luajit-2.1/luajit-request/luajit-request/init.lua'
	no file '/usr/local/share/lua/5.1/luajit-request/luajit-request/init.lua'
	no file '/usr/local/share/lua/5.1/luajit-request/luajit-request/init/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/luajit-request/luajit-request/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/luajit-request/luajit-request/init/init.lua'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/luajit-request/luajit-request/init.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/luajit-request/luajit-request/init.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/luajit-request/luajit-request/init.so'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/luajit-request.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/luajit-request.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/luajit-request.so'
Error: [love "boot.lua"]:276: utils.lua:24: module 'ui.utils' not found:
	no field package.preload['ui.utils']
	no 'ui/utils' in LOVE game directories.
	no file 'ui/utils' in LOVE paths.
	no file './ui/utils.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/luajit-2.1/ui/utils.lua'
	no file '/usr/local/share/lua/5.1/ui/utils.lua'
	no file '/usr/local/share/lua/5.1/ui/utils/init.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/ui/utils.lua'
	no file '/nix/store/kvc6zy9pavv5k2vd419zzb992kwjjqqr-luajit-2.1.1713773202/share/lua/5.1/ui/utils/init.lua'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/ui/utils.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/ui/utils.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/ui/utils.so'
	no file '/nix/store/gqsjg9k1gvyrfpv5h5vgp9pky4gz0dpa-lua5.1-nfd-scm-1/lib/lua/5.1/ui.so'
	no file '/nix/store/br24aizl64vk638xkw7gq479grz4fxnq-lua5.1-subprocess-bfa8e9/lib/lua/5.1/ui.so'
	no file '/nix/store/6p90k0szyd052csv8x4cdzs35m77k5h6-lua5.1-lsqlite3-0.9.6-1/lib/lua/5.1/ui.so'
stack traceback:
	[love "boot.lua"]:352: in function <[love "boot.lua"]:348>
	[C]: in function 'error'
	[love "boot.lua"]:276: in function <[love "boot.lua"]:126>
	[C]: in function 'xpcall'
	[love "boot.lua"]:362: in function <[love "boot.lua"]:355>
	[C]: in function 'xpcall'

@L1Z3

L1Z3 commented Jul 22, 2024

Copy link
Copy Markdown

Nope, I did the same (though I seem to have a different hash from you?), see my copy of the package here.

maintainers: add ulysseszhan
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove dotnet-runtime here because it is actually useless. Piton checks the existence of a .NET runtime by looking at a specific location (namely piton-runtime) in the game installation dir, which we can do nothing about at this stage. Relevant source code: https://github.com/Popax21/Piton/blob/21c7868d06007f0c5e7d9030a0109fe892df1bf3/apphost/src/main.rs#L118-L128

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove dotnet-runtime here because it is actually useless. Piton checks the existence of a .NET runtime by looking at a specific location (namely piton-runtime) in the game installation dir, which we can do nothing about at this stage. Relevant source code: https://github.com/Popax21/Piton/blob/21c7868d06007f0c5e7d9030a0109fe892df1bf3/apphost/src/main.rs#L118-L128

Piton does check for a system runtime; the code for that is directly above the snippet you linked.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, but somehow the piton-runtime dir is still populated.

@fxzzi

fxzzi commented Jan 12, 2025

Copy link
Copy Markdown
Contributor

i dont use the map editor thing, but the main mod manager aspect of olympus seems to be working great for me. Thanks!

@IogaMaster

Copy link
Copy Markdown
Contributor

image
@Petingoso, this is almost a year in the works!
I want to applaud you for your dedication!

@teknolog1k

Copy link
Copy Markdown
Contributor

Looks like stable has moved to 25.01.22.02 (commit 4c0429b on the Olympus github). Aside from that, everything looks good!

@JumpIn-Git

JumpIn-Git commented Mar 5, 2025

Copy link
Copy Markdown

cant wait for this to release! right now i need im using the flatpak but need to manually open celeste via steam-run, setting the env variable to steam-run doesnt seem to do anything, maybe because its a flatpak

@cogsandsquigs

Copy link
Copy Markdown

+1, can't wait for a nixos version!

@pyrox0

pyrox0 commented Mar 27, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 309327


x86_64-linux

✅ 1 package built:
  • olympus

@pyrox0

pyrox0 commented Mar 27, 2025

Copy link
Copy Markdown
Member

Hey, just looked at this. My only suggestion would be to keep the core package build in its own package(renamed to olympus-unwrapped, but pull all the wrappers into a separate package(which would take olympus), that way if someone is testing wrapper changes, they are not rebuilding the entire package every time. This also helps evaluations since things can be more easily split up and parallelized. It should be as simple as taking the wrapper logic from here into a new package, pulling this as an input to that package, and then doing the same wrapper logic. I hope that makes sense, and I would be glad to make a branch with code explaining what I mean if that is more helpful. Thanks for this big contribution to nixpkgs, as a celeste player I'd love to see this in-tree!

@Petingoso

Copy link
Copy Markdown
Contributor Author

Hey, just looked at this. My only suggestion would be to keep the core package build in its own package(renamed to olympus-unwrapped, but pull all the wrappers into a separate package(which would take olympus), that way if someone is testing wrapper changes, they are not rebuilding the entire package every time. This also helps evaluations since things can be more easily split up and parallelized. It should be as simple as taking the wrapper logic from here into a new package, pulling this as an input to that package, and then doing the same wrapper logic. I hope that makes sense, and I would be glad to make a branch with code explaining what I mean if that is more helpful. Thanks for this big contribution to nixpkgs, as a celeste player I'd love to see this in-tree!

That makes sense, yes.
I might attempt to do that in, a few days, just have a few questions.
So it will be a meta package that refers to this one. And do I also commit and add the changes here or should I make this one the main only and make a new PR mentioning this one?

@UlyssesZh

Copy link
Copy Markdown
Member

Do it in this PR.

Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
@Petingoso

Copy link
Copy Markdown
Contributor Author

This is just a working draft what I managed to reach. I'm betting it needs a bit of polishing but it should be fine after.

Comment thread pkgs/by-name/ol/olympus/unwrapped.nix Outdated
Comment thread pkgs/by-name/ol/olympus/unwrapped.nix Outdated
@pyrox0

pyrox0 commented Apr 30, 2025

Copy link
Copy Markdown
Member

Pretty happy with the changes, just a few tiny changes and then I'm happy with this! Thank you for working so hard on this PR, as a Celeste player I'm glad to see this pretty much ready to go.

Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/unwrapped.nix Outdated
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/update.sh Outdated
Comment thread pkgs/by-name/ol/olympus/update.sh Outdated
Comment thread pkgs/by-name/ol/olympus/unwrapped.nix Outdated
@UlyssesZh

Copy link
Copy Markdown
Member

I think you should squash your later two commits. If you put the unwrapped package in olympus.passthru.unwrapped, just have one commit of olympus: init at xxx. If you put the unwrapped package in olympus-unwrapped, you can either have two commits with olympus-unwrapped: init at xxx and olympus: init at xxx, or have one commit with olympus{,-unwrapped}: init at xxx.

@UlyssesZh UlyssesZh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should be olympus{,-unwrapped}: init at xxx.

Comment thread pkgs/by-name/ol/olympus-unwrapped/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus-unwrapped/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus-unwrapped/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus-unwrapped/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/update.sh Outdated
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
Comment thread pkgs/by-name/ol/olympus/package.nix Outdated
@Petingoso

Copy link
Copy Markdown
Contributor Author

Note: after testing myself the overrides, i cannot seem to properly change the resulting package.
nix-build . -A olympus --arg skipHandlerCheck true for example. I ask for someone to try reproduce and if so or to help find what's wrong.

@UlyssesZh

Copy link
Copy Markdown
Member

This is because --arg is passed to nixpkgs, not the package override. Try this instead:

nix-build -E 'with import ./. {}; olympus.override { skipHandlerCheck = true; }'

Or this:

nix build --impure --expr 'with import ./. {}; olympus.override { skipHandlerCheck = true; }'

@pyrox0

pyrox0 commented May 4, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 309327


x86_64-linux

✅ 2 packages built:
  • olympus
  • olympus-unwrapped

@UlyssesZh UlyssesZh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. The PR title and the commit message should still be changed (olympus{,-unwrapped}.

Comment thread pkgs/by-name/ol/olympus-unwrapped/update.sh Outdated
@pyrox0

pyrox0 commented May 4, 2025

Copy link
Copy Markdown
Member

When trying to launch celeste, it appears that it cannot launch, due to <olympus path>/lib/olympus/suppress-output not existing. The build script for olympus-unwrapped should copy the script(https://github.com/EverestAPI/Olympus/blob/main/suppress-output.sh) to the mentioned $out/lib/olympus/suppress-output path.

Comment thread pkgs/by-name/ol/olympus-unwrapped/package.nix Outdated
This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods.
This is based on this [draft](NixOS#295258), with the original authors permission.

It is able to launch from the app but for proper use depends on
overriding celesteWrapper. See package.nix for details.

I only have to note that it has a popup complaining about
finishing the installation but that's due to xdg-mime
x-scheme-handler/everest not being set.

Needs [this](NixOS#309026) which was
merged.

Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works
as expected, being the installation managed by the program.

Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic
executables, wontfix.

olympus: fixed zenity argument

olympus: bugfix add openssl to fhs

olympus: fixed to use the default nfd instead of patched version

olympus: changed location of ndf arg

olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up

olympus: deleted zenity.patch

Due to nfd lua package being fixed, this patch is no longer needed

olympus: fix use of wrong nfd package

olympus: bumped up version to 24.07.06.02

olympus: format files with nixfmt-rfc

olympus: chores: comments, fixed lib conventions

olympus: make wrappers properly, use standard build process, misc fixes

olympus: update version, src; add updateScript

olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes

olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env

olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change
olympus-with-steam-run: init

olympus: more flexible celeste wrapper

olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath

olympus: minor fix with lua cpath; add xdg-utils to path

olympus: use standard lua-subprocess instead of fork

olympus: make MiniInstaller be properly wrapped

olympus: add option to skip handler

olympus: tweaked platforms, tweaked miniinstaller-fhs

olympus-with-steam-run: comment for reminder on fixing issues with
relative paths

olympus: removed extraneous package

olympus: add extra wrapper options for mininstaller and loenn

olympus: add more explicit comments, bump version

olympus: fixed mismatched hash in olympus

olympus: changed proprieties of miniinstaller-fhs (NixOS#336576)

olympus: tweak miniinstallerWrapper

olympus: migrated to deps.json (NixOS#362278)

olympus: remove meta.mainProgram explicitly (NixOS#358550)

olympus: bump to 24.12.28.01
changes to new install process of net8.0

olympus : format

olympus: changed install path, tweaked meta info

olympus: bump to 25.02.07.01

olympus: update luasqlite download

olympus: split into wrapped version for modularity

olympus{,-wrapped}: init at 25.04.20.01

olympus: tweak maintainer script

olympus: formatting

olympus{,-unwrapped}: move update script to -unwrapped; remove hardcoded
pnam in -unwrapped; clean up properties

olympus-unwrapped: fix wrong attr in update.sh; install new needed file

@fxzzi fxzzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running locally on my own system without issues for the past several months. So approving.

@pyrox0

pyrox0 commented Jun 13, 2025

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 309327

Not sure why there's no build logs here, but the packages work fine. Currently, loenn and miniinstaller work just fine with no additional tweaks, but we should maybe look into providing a default "known-good" fhs environment for olympus users, maybe through a NixOS module(which could also detect use of steam(through programs.steam.enable) and use steam-run as the launch environment instead)

However, as a fully-free system, this looks good for now. So sorry about the long wait on my review, I've been burned out. Thank you so much for the PR, and I do hope you continue to contribute to nixpkgs, this is good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaging request: olympus