osu-lazer fails to build with removed dependencies by fetch-deps

[gepbird]

Describe the bug

Building osu-lazer fails after running the fetch-deps script after #362278

Steps To Reproduce

Steps to reproduce the behavior:

1. checkout master (4d982ce)
2. $(nix-build -A osu-lazer.fetch-deps)
3. observe the changes to deps.json:

diff of deps.json

diff --git a/pkgs/by-name/os/osu-lazer/deps.json b/pkgs/by-name/os/osu-lazer/deps.json
index e6f537882615..df5a3f644615 100644
--- a/pkgs/by-name/os/osu-lazer/deps.json
+++ b/pkgs/by-name/os/osu-lazer/deps.json
@@ -4,11 +4,6 @@
     "version": "13.0.1",
     "hash": "sha256-3rlsVaouPVH3BD0SobUbVojHuZzNUThQnwbteDtWQ2g="
   },
-  {
-    "pname": "CodeFileSanity",
-    "version": "0.0.37",
-    "hash": "sha256-+BoA4FdDUfeREdc42xbnonh3IBLOjzyrrBosaswbSg4="
-  },
   {
     "pname": "DiffPlex",
     "version": "1.7.2",
@@ -294,11 +289,6 @@
     "version": "2023.3.0",
     "hash": "sha256-/Eykez68qYMO5mlmUelzAke8aJehyp8fspO5Z+yt5G4="
   },
-  {
-    "pname": "JetBrains.ReSharper.GlobalTools",
-    "version": "2023.3.3",
-    "hash": "sha256-Nn3imJvnqLe02gR1GyUHYH4+XkrNnhLy9dyCjJCkB7M="
-  },
   {
     "pname": "managed-midi",
     "version": "1.10.1",
@@ -574,11 +564,6 @@
     "version": "3.14.0",
     "hash": "sha256-CuP/q5HovPWfAW3Cty/QxRi7VpjykJ3TDLq5TENI6KY="
   },
-  {
-    "pname": "NVika",
-    "version": "3.0.0",
-    "hash": "sha256-zgg8aUuIFQ4EZHScy+YHmkwDE9K5vzUJF8s9aiJNFuw="
-  },
   {
     "pname": "OpenTabletDriver",
     "version": "0.6.4",
@@ -609,11 +594,6 @@
     "version": "2024.802.0",
     "hash": "sha256-vyRWbdPUp5n8hJPJReU9LUy2o/bwwLT1po9f2M16tMA="
   },
-  {
-    "pname": "ppy.LocalisationAnalyser.Tools",
-    "version": "2024.802.0",
-    "hash": "sha256-bniBSY8rS005OHO/ixn2NFM0/KIMiawHyMSXhlAEqwc="
-  },
   {
     "pname": "ppy.ManagedBass",
     "version": "2022.1216.0",

diff of deps.nix (if building before the switch to deps.json, for example on the bisected commit)

diff --git a/pkgs/by-name/os/osu-lazer/deps.nix b/pkgs/by-name/os/osu-lazer/deps.nix
index f013c29e1a7d..84820ef50bd5 100644
--- a/pkgs/by-name/os/osu-lazer/deps.nix
+++ b/pkgs/by-name/os/osu-lazer/deps.nix
@@ -8,11 +8,6 @@
     version = "13.0.1";
     hash = "sha256-3rlsVaouPVH3BD0SobUbVojHuZzNUThQnwbteDtWQ2g=";
   })
-  (fetchNuGet {
-    pname = "CodeFileSanity";
-    version = "0.0.37";
-    hash = "sha256-+BoA4FdDUfeREdc42xbnonh3IBLOjzyrrBosaswbSg4=";
-  })
   (fetchNuGet {
     pname = "DiffPlex";
     version = "1.7.2";
@@ -298,11 +293,6 @@
     version = "2023.3.0";
     hash = "sha256-/Eykez68qYMO5mlmUelzAke8aJehyp8fspO5Z+yt5G4=";
   })
-  (fetchNuGet {
-    pname = "JetBrains.ReSharper.GlobalTools";
-    version = "2023.3.3";
-    hash = "sha256-Nn3imJvnqLe02gR1GyUHYH4+XkrNnhLy9dyCjJCkB7M=";
-  })
   (fetchNuGet {
     pname = "managed-midi";
     version = "1.10.1";
@@ -578,11 +568,6 @@
     version = "3.14.0";
     hash = "sha256-CuP/q5HovPWfAW3Cty/QxRi7VpjykJ3TDLq5TENI6KY=";
   })
-  (fetchNuGet {
-    pname = "NVika";
-    version = "3.0.0";
-    hash = "sha256-zgg8aUuIFQ4EZHScy+YHmkwDE9K5vzUJF8s9aiJNFuw=";
-  })
   (fetchNuGet {
     pname = "OpenTabletDriver";
     version = "0.6.4";
@@ -613,11 +598,6 @@
     version = "2024.802.0";
     hash = "sha256-vyRWbdPUp5n8hJPJReU9LUy2o/bwwLT1po9f2M16tMA=";
   })
-  (fetchNuGet {
-    pname = "ppy.LocalisationAnalyser.Tools";
-    version = "2024.802.0";
-    hash = "sha256-bniBSY8rS005OHO/ixn2NFM0/KIMiawHyMSXhlAEqwc=";
-  })
   (fetchNuGet {
     pname = "ppy.ManagedBass";
     version = "2022.1216.0";

4. nix-build -A osu-lazer
5. observe the failure: Version 2023.3.3 of package jetbrains.resharper.globaltools is not found in NuGet feeds /build/nuget.6jmUII/source".

Expected behavior

Either no change to deps.json or the package building with the changes.

Screenshots

Additional context

Bisected to 3cc4563. I'm not sure whether we should patch out the dependency in the package that probably shouldn't be used in build time (in this case jetbrains.resharper.globaltools) or the dotnet tools need some adjustment.

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.11.5-zen1, NixOS, 25.05 (Warbler), 25.05.20241213.3566ab7`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.91.1
System type: x86_64-linux
Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux
Features: gc, signed-caches
System configuration file: /etc/nix/nix.conf
User configuration files: /home/gep/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/gep/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/gep/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/gep/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf
Store directory: /nix/store
State directory: /nix/var/nix
Data directory: /nix/store/smghprxmwyp707kqljlm4fsxm7h5wd72-lix-2.91.1/share`
 - nixpkgs: `/nix/store/22r7q7s9552gn1vpjigkbhfgcvhsrz68-source`

Notify maintainers

@GGG-KILLER

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.

[GGG-KILLER]

This is weird, no logic was changed from nuget-to-nix to nuget-to-json.

Will investigate though.

[GGG-KILLER]

Ok, found the issue, it was on #362278 (comment) where I failed to properly validate the re-generated lockfiles.

It seems tools showing up on lockfiles depended on the old behavior of the jq -r 'if has("source") then .source else "" end' returning null and now the new behavior is to return "", which makes so that tools are ignored.

Maybe we should look into if this check is really necessary. @corngood any opinions?