Add AzerothCore cluster service integration by VG-prog · Pull Request #37 · walkline/ToCloud9

VG-prog · 2026-05-22T21:03:24Z

This replaces the previous draft PR split (#27-#36).

Those drafts were opened from stacked branches while targeting master, which made the GitHub diffs misleading: each PR included earlier slices and a lot of unrelated-looking overlap. This PR intentionally presents the current ToCloud9 side of the AzerothCore cluster integration as one honest review surface instead of pretending the stacked branches are independent.

What this adds

Shared cluster contracts for realm-aware character, chat, group, guild, matchmaking, registry, and worldserver coordination, including generated protobuf code.
Service-discovery and readiness hardening for game servers, gateways, and matchmaking, including degraded world-loop handling that preserves ownership but drains new player placement until recovery.
Gateway-side cluster routing and client presentation paths for sessions, redirects, chat/channel packets, social data, group frames, guild packets, guild bank interactions, LFG, arena teams, and player-state extraction.
Character, chat, mail, and social-service updates needed for realm-aware and clustered operation.
Distributed group state, including roster identity, live member-state routing, ready checks, raid/subgroup flags, and cleanup behavior.
Distributed guild and charter flows, plus transactional guild-bank coordination.
Crossrealm LFG, battleground, and arena coordination, including materialization and route ownership support.
Game-server sidecar APIs needed by the AzerothCore integration.
Auth and character database migrations for the new cluster persistence requirements.

Review notes

The implementation is large because the pieces share protobuf contracts, generated clients, gateway listeners, service events, sidecar calls, and database state. Splitting this into independent PRs against master is not currently truthful unless the earlier foundation PRs are merged first and later PRs retarget those merged bases.

The main intention here is to give a correct review target for the current integration state. If you prefer a sequential merge plan, the safe order is roughly:

contracts/generated/shared helpers;
discovery/readiness;
gateway routing and packet presentation;
character/chat/mail/social services;
group state;
guild and guild bank;
matchmaking/LFG/BG/arena;
sidecar APIs;
SQL migrations.

That sequence should be created as a real stacked series only after each base exists in the upstream repository or in an agreed upstream integration branch.

Validation

Run on the cleaned branch:

git diff --check upstream/master..vg/tc9-cluster-services
env GOCACHE=/tmp/tc9-go-build GOFLAGS=-buildvcs=false go build ./...
env GOCACHE=/tmp/tc9-go-build GOFLAGS=-buildvcs=false make install

All three passed locally.

Add the shared protobuf, generated runtime code, events, GUID helpers, auth identity helpers, and configuration contracts used by clustered gateway, registry, group, guild, matchmaking, and sidecar flows. Tests, local tooling, and broad documentation are intentionally excluded from this upstream-focused scope.

Wire service discovery, map readiness, stale-safe health and metrics observers, degraded game-server health handling, gateway-scoped cleanup, and shared GUID allocation support. Registry and health code now distinguish world-loop degraded state from process or transport death while preserving live map ownership.

Keep world-loop degraded game servers registered for ownership and existing lookups, but mark them as non-admitting so new player placement skips them. Clear the drain state on successful health recovery and fall back to healthy all-map nodes when an assigned owner is degraded.

Route gateway sessions through cluster-aware worldserver selection, native transport handoff, bounded retry/backoff, cross-service event listeners, and client-facing packet rendering for social, group, guild, guild bank, LFG, battleground, arena, mail, channel, and player-state flows.

Extend character, chat, and mail services for clustered realm identity, Real ID/account lookups, channel membership and moderation, crossrealm whisper policy, online-state broadcasts, and arena-team persistence used by gateway routing.

Add clustered group authority for realm-scoped membership, native LFG materialized groups, member-state freshness, latest-state catch-up, receiver-aware fanout, offline cleanup, debug tracing, and persistent group identity support.

Add realm-scoped guild service routing, charter offer/sign/query/signature handling, native petition persistence, guild cache lifecycle, gateway-facing events, and debug logging for same-realm clustered guild workflows.

Add guildserver-owned same-realm guild bank item, money, tab, log, text, split, merge, withdraw-limit, rollback, and idempotency helpers backed by direct MySQL transactions and guidserver item allocation.

Extend matchmaking and mysqlreverseproxy for crossrealm LFG proposal materialization, persistent instance routes, battleground owner placement, arena-team persistence and rated-result handling, character-state listeners, and route-aware SQL interception.

Extend the libsidecar C ABI and Go bridge with grouped member-state events, guild and LFG RPCs, arena-team and item APIs, monitoring/readiness behavior, config loading, and consumer handlers required by the clustered AzerothCore integration.

Add auth and character database migrations for Real ID friends, crossrealm group identity, LFG route persistence, stable petition IDs, and guild bank idempotency/locking changes required by clustered services.

walkline

Thanks for the PR! I will review it in several sessions. This is the first one.

walkline · 2026-05-23T15:44:28Z

@@ -0,0 +1,66 @@
+SET @tc9_has_petition_id := (


This migration is not needed.

walkline · 2026-05-23T15:44:52Z

@@ -0,0 +1 @@
+DROP TABLE IF EXISTS `tc9_guild_bank_lock`;


This one not needed as well.

walkline · 2026-05-23T15:52:11Z

+	B = fixedLittleEndianBytes(s._B, 32)
+	g = bigIntToBytesLittleEndian(_g)
+	N = fixedLittleEndianBytes(bigIntToBytesLittleEndian(_N), 32)
+	_s = fixedLittleEndianBytes(s._s, 32)


Wondering what was wrong with previous SRP implementation?

walkline · 2026-05-23T15:55:23Z

-	if err != nil {
-		return nil, err
-	}


I would prefer to explicitly show the error rather than hide the issue.

walkline · 2026-05-23T15:58:52Z

+
 func (s *AuthSession) write(writer io.Writer, v ...interface{}) error {
-	var err error
+	packet := new(bytes.Buffer)


Hm, why are we using an additional buffer instead of writing directly to the writer?

walkline · 2026-05-23T17:16:19Z

+	authDB, err := sql.Open("mysql", conf.AuthDBConnection)
+	if err != nil {
+		log.Fatal().Err(err).Msg("can't connect to auth db")
+	}
+	defer authDB.Close()
+	configureDBConn(authDB)


Hm, I don't know if we want the auth DB in charserver. I understand that it's required for Real ID, but I don't see this feature as super important. Maybe we could make it optional and hide it behind config?

Sure thing, ill approach it!

walkline · 2026-05-23T17:29:34Z

+  account_id_low INT UNSIGNED NOT NULL,
+  account_id_high INT UNSIGNED NOT NULL,


What is low and high id? Why its required here?

walkline · 2026-05-23T17:31:24Z

+
+	team := ArenaTeamDetails{}
+	err = db.QueryRowContext(ctx, `
+SELECT arenaTeamId, name, captainGuid, type, rating, weekGames, weekWins, seasonGames, seasonWins, `+"`rank`"+`, backgroundColor, emblemStyle, emblemColor, borderStyle, borderColor


Can we use prepared statements in this repo, like we do in other places?

walkline · 2026-05-23T17:38:07Z

+
+	lockName := fmt.Sprintf("tc9_arena_team_create:%d", request.RealmID)
+	var locked int
+	if err := db.QueryRowContext(ctx, "SELECT GET_LOCK(?, 5)", lockName).Scan(&locked); err != nil {


Let's avoid locking when possible. I assume it's there to make sure we don't create the same team twice. I'm not sure if that's even possible, but theoretically, if it is, then it's probably better to add a uniqueness constraint to the name field, for example. Then I think we can remove this lock.

VG-prog added 11 commits May 22, 2026 21:49

feat(Cluster/Groups): Add distributed group state

957badd

Add clustered group authority for realm-scoped membership, native LFG materialized groups, member-state freshness, latest-state catch-up, receiver-aware fanout, offline cleanup, debug tracing, and persistent group identity support.

feat(Cluster/Guilds): Add distributed guild services

bdd5fd2

Add realm-scoped guild service routing, charter offer/sign/query/signature handling, native petition persistence, guild cache lifecycle, gateway-facing events, and debug logging for same-realm clustered guild workflows.

feat(Cluster/GuildBank): Add transactional bank coordination

a24a16b

Add guildserver-owned same-realm guild bank item, money, tab, log, text, split, merge, withdraw-limit, rollback, and idempotency helpers backed by direct MySQL transactions and guidserver item allocation.

fix(DB/Cluster): Add cluster persistence migrations

e2a6835

Add auth and character database migrations for Real ID friends, crossrealm group identity, LFG route persistence, stable petition IDs, and guild bank idempotency/locking changes required by clustered services.

walkline requested changes May 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add AzerothCore cluster service integration#37

Add AzerothCore cluster service integration#37
VG-prog wants to merge 11 commits into
walkline:masterfrom
VG-prog:vg/tc9-cluster-integration-review

VG-prog commented May 22, 2026

Uh oh!

walkline left a comment

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

VG-prog May 28, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

walkline May 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		account_id_low INT UNSIGNED NOT NULL,
		account_id_high INT UNSIGNED NOT NULL,

Conversation

VG-prog commented May 22, 2026

What this adds

Review notes

Validation

Uh oh!

walkline left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants